Revise HTML update methods order of operations#60553
Merged
Merged
Conversation
Ensure a consistent order of operations for all the new HTML insertion methods (appendHTML, prependHTML, beforeHTML, afterHTML, replaceWithHTML) - The trusted types createHTML test should always come first - ChildNode methods should then ensure the parent can accept HTML, or throw - Correctly handle <template> in all the methods (e.g. `template.appendHTML`, `template.content.beforeHTML`) - Assert some edge cases in WPT (e.g. trusted types moves nodes around) See spec PR: whatwg/html#12528 Bug: 491743369 Change-Id: I5e587ae12faad3d706e2d993bd1aa88500b3e6be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7915261 Commit-Queue: Noam Rosenthal <nrosenthal@google.com> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/main@{#1645229}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7915261
branch
from
b5e7b47 to
fbcbe28
Compare
wpt-pr-bot
approved these changes
Jun 11, 2026
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure a consistent order of operations for all the new HTML insertion
methods (appendHTML, prependHTML, beforeHTML, afterHTML,
replaceWithHTML)
(e.g.
template.appendHTML,template.content.beforeHTML)See spec PR: whatwg/html#12528
Bug: 491743369
Change-Id: I5e587ae12faad3d706e2d993bd1aa88500b3e6be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7915261
Commit-Queue: Noam Rosenthal <nrosenthal@google.com>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1645229}