Improve testing dialog closedby and requestClose#50808
Merged
Merged
Conversation
See this request: whatwg/html#10983 (comment) plus this comment: https://chromium-review.googlesource.com/c/chromium/src/+/6245064/comments/e932d31a_c996d18e This just adds more testing of dialog closedby and requestClose, to make sure close watchers are still set up, the `:open` pseudo class works properly, events get fired correctly, etc., when the dialog `open` attribute is manually added and removed. Bug: 376516550 Change-Id: Ibdee09c5f722db2ce97c64c38c39726c1503e1d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6253798 Auto-Submit: Mason Freed <masonf@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Reviewed-by: Luke <lwarlow@igalia.com> Cr-Commit-Position: refs/heads/main@{#1422074}
wpt-pr-bot
approved these changes
Feb 19, 2025
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See this request:
whatwg/html#10983 (comment)
plus this comment:
https://chromium-review.googlesource.com/c/chromium/src/+/6245064/comments/e932d31a_c996d18e
This just adds more testing of dialog closedby and requestClose, to
make sure close watchers are still set up, the
:openpseudo classworks properly, events get fired correctly, etc., when the dialog
openattribute is manually added and removed.Bug: 376516550
Change-Id: Ibdee09c5f722db2ce97c64c38c39726c1503e1d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6253798
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Luke <lwarlow@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1422074}