fix: export generated C/C++ ABI symbols under hidden visibility#25
Merged
Conversation
|
Thanks for the fix! I will test later today and report any more issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Generated C and C++ headers now tag every exported prototype with a portable
WEAVEFFI_APIvisibility macro, so a non-Rust backend that implements the header exports its symbols even under hidden default visibility (-fvisibility=hidden, the release-build norm and the MSVC default). Consumers resolve it to__declspec(dllimport)on Windows; it's benign elsewhere. Deprecated functions use a companionWEAVEFFI_DEPRECATEDmacro that also compiles under MSVC.Changes
cabirenderer; emit the macro definitions from the C and C++ generators.__attribute__((deprecated))with a portableWEAVEFFI_DEPRECATEDmacro.-fvisibility=hiddenand asserts symbols export.Closes #23