feat: default on-disk retrieval of skipped diffs; dedupe skip callout#129
Merged
Conversation
… callout Retrieval of size-dropped diffs is now on by default (was the opt-in --retrieve-skipped); disable with --no-retrieve-skipped or CODE_REVIEW_RETRIEVE_SKIPPED=0. Skipped files used to be listed twice in the summary: once in the deterministic WARNING callout and again in the reviewer's prose, because the prompt asked it to re-list them and restate coverage. The callout is now the single canonical listing and is retrieval-aware (staged for on-demand retrieval rather than "not reviewed"); the reviewer only reports which staged files it actually read. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Code ReviewRisk: Medium — issues that should be addressed before merge. This MR flips 1 issue found:
Review usage: 493,815 in (422,400 cached) / 7,534 out tokens — $0.3971 (cloudflare-ai-gateway/gpt-5.4, thinking: medium) Reviewed by @weareikko/code-review v0.8.3 for commit 2c6e3fb. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two changes to how the reviewer handles files dropped by the diff size budget.
1. On-disk retrieval is now on by default. Previously opt-in via
--retrieve-skipped. Dropped diffs are staged on disk so the reviewer can read the highest-risk ones on demand instead of losing them, which should improve coverage on large MRs across the board. Disable with--no-retrieve-skippedorCODE_REVIEW_RETRIEVE_SKIPPED=0/false/no/off. The legacy--retrieve-skippedflag still works.2. Skipped files are no longer listed twice in the summary. They used to appear in both the deterministic
[!WARNING]callout and the reviewer's own prose (the prompt asked it to re-list them and restate coverage). The callout is now the single canonical listing, and it's retrieval-aware — it frames dropped files as "staged for on-demand retrieval; see the review summary for which were read" instead of the misleading "were NOT reviewed". Under retrieval the reviewer's prose only reports which staged files it actually read (non-duplicate info).Changes
src/config.ts:retrieveSkippeddefaultstruevia newresolveRetrieveSkipped(); added--no-retrieve-skippednegation flag.src/cli.ts,docs/configuration.md: help/doc updates for the flipped default and new flag.src/gitlab-review.ts: dropped the "mention/restate in your summary" instructions from the prompt (kept the honesty guidance); thread aretrievedflag intoReviewSizeNotice.src/posting.ts:buildSizeNoticeBlockrenders retrieval-aware wording when diffs were staged.Verification
npm run checkpasses (lint, format, typecheck, 698 unit tests).