Refactor Electron raw print IPC#615
Conversation
|
Warning Review limit reached
More reviews will be available in 56 minutes and 28 seconds. Learn how PR review limits work. To continue reviewing without waiting, enable usage-based billing in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
📊 Test Coverage Report
Coverage Legend
|
🚀 Deployment Summary
🔗 Quick Links❌ Failed Tests (4 total)pos-checkout.spec.ts
📋 Full error details (first 5)pos-checkout.spec.ts - should open checkout modalProject: pos-checkout.spec.ts - should show order total in checkoutProject: pos-checkout.spec.ts - should cancel checkout and return to cartProject: pos-checkout.spec.ts - should complete an orderProject: 📸 Failure Screenshots🔗 Debug Links
🤖 Updated by GitHub Actions |






Summary
ipc-print.electronhelper for IPC lookup,Uint8Array→number[]conversion, the 30s renderer timeout, and timer cleanup.apps/electronat the companion Electron PR commit that centralizes main-process raw-print delivery.Design decisions (preserve through rebases)
print-raw-serial/print-raw-usbwith{ device, data }andprint-raw-tcpwith{ host, port, data }.window.ipcRendererandwindow.electronAPI?.ipcRenderer, fixing the network adapter fallback gap without changing the preload contract.Companion PRs / cross-repo
Test plan
apps/electron:pnpm ts:checkapps/electron:pnpm lint(passes with pre-existing warnings only)apps/electron:pnpm run test:serial-printerapps/electron:pnpm run test:winspool-printerapps/electron:pnpm run test:printer-discoveryapps/electron:pnpm run test:raw-printapps/electron:pnpm testpackages/printer:npx tsc --noEmit -p tsconfig.jsonpackages/printer:pnpm exec vitest run src/transport/__tests__/serial-adapter.electron.test.ts🤖 Generated with Claude Code