Fix Electron 1.9.6 release pin#612
Closed
wcpos-bot[bot] wants to merge 1 commit into
Closed
Conversation
Merged
Contributor
📊 Test Coverage Report
Coverage Legend
|
Contributor
🚀 Deployment Summary
🔗 Quick Links🤖 Updated by GitHub Actions |
Contributor
|
Closing as superseded. This pins |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/electronsubmodule fromaab0ecftod876878.d876878is the Electron release commit that bumps@wcpos/app-electronfrom1.9.5to1.9.6.main.Design decisions
apps/electrontod876878— direct child of the previous pin and only changes Electronpackage.jsonversion from1.9.5to1.9.6.Test plan
aab0ecfhas@wcpos/app-electronversion1.9.5.d876878has@wcpos/app-electronversion1.9.6.mainonly changesapps/electron.pnpm install,pnpm lint,pnpm typecheck,pnpm test, andpnpm test:cicould not complete in the local container becauseuniwindpostinstall fails loadinglibsecret-1.so.0.Known blockers
libsecret-1.so.0; pnpm dependency lifecycle scripts fail before project lint/typecheck/test commands run.