Skip to content

Fix Electron 1.9.6 release pin#612

Closed
wcpos-bot[bot] wants to merge 1 commit into
mainfrom
release/1.9.6
Closed

Fix Electron 1.9.6 release pin#612
wcpos-bot[bot] wants to merge 1 commit into
mainfrom
release/1.9.6

Conversation

@wcpos-bot

@wcpos-bot wcpos-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Updates the apps/electron submodule from aab0ecf to d876878.
  • d876878 is the Electron release commit that bumps @wcpos/app-electron from 1.9.5 to 1.9.6.
  • Follow-up for Release v1.9.6 #611 review thread Release v1.9.6 #611 (comment), which was merged before the fix landed on main.

Design decisions

  • Pin apps/electron to d876878 — direct child of the previous pin and only changes Electron package.json version from 1.9.5 to 1.9.6.

Test plan

  • Confirmed previous Electron pin aab0ecf has @wcpos/app-electron version 1.9.5.
  • Confirmed new Electron pin d876878 has @wcpos/app-electron version 1.9.6.
  • Confirmed branch diff versus main only changes apps/electron.
  • pnpm install, pnpm lint, pnpm typecheck, pnpm test, and pnpm test:ci could not complete in the local container because uniwind postinstall fails loading libsecret-1.so.0.

Known blockers

  • Local validation environment is missing libsecret-1.so.0; pnpm dependency lifecycle scripts fail before project lint/typecheck/test commands run.

@wcpos-bot wcpos-bot Bot mentioned this pull request Jun 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📊 Test Coverage Report

Package Statements Branches Functions Lines
@wcpos/core 🔴 23.1% 🔴 26.9% 🔴 22.3% 🔴 22.6%
@wcpos/components 🔴 24.6% 🔴 27.3% 🔴 16.8% 🔴 24.3%
@wcpos/database 🟡 60.2% 🔴 55.0% 🟡 62.7% 🔴 59.7%
@wcpos/hooks 🔴 52.4% 🔴 50.1% 🔴 45.0% 🔴 52.4%
@wcpos/utils 🔴 55.9% 🟡 61.5% 🟡 71.4% 🔴 53.8%
@wcpos/query 🟢 83.9% 🟡 76.9% 🟡 77.7% 🟢 84.0%
Average 🔴 50.0% 🔴 49.6% 🔴 49.3% 🔴 49.5%
Coverage Legend
  • 🟢 Good (≥80%)
  • 🟡 Moderate (60-79%)
  • 🔴 Needs improvement (<60%)
  • ⚪ No coverage data
--- 🤖 Updated by GitHub Actions • [View full report](https://github.com/wcpos/monorepo/actions/runs/27685830154)

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Deployment Summary

Item Status
Preview URL https://wcpos--f4aggpu8el.expo.app
E2E Tests ✅ Passed
Commit 5e5a80e

🔗 Quick Links


🤖 Updated by GitHub Actions

@kilbot

kilbot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Closing as superseded. This pins apps/electron to d876878, which is the pre-squash commit from electron #276's branch — git compare shows it diverged from electron main (not on any branch). #613 already pinned monorepo main to 5851f72e, the canonical squash-merged electron 1.9.6 commit (identical to electron main HEAD). Merging this would regress the pin to a dead commit, so closing rather than resolving the conflict.

@kilbot kilbot closed this Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant