Remove sync app info IPC shims#277
Conversation
|
Warning Review limit reached
More reviews will be available in 14 minutes and 4 seconds. Learn how PR review limits work. To continue reviewing without waiting, enable usage-based billing in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository: wcpos/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
getBasePathSyncandgetAppVersionSyncsynchronous IPC registration modules and their side-effect imports.window.electron.basePathdirectly in the preload fromprocess.resourcesPath, preserving the existingfile://.../diststring shape with no trailing slash.app.getVersion()once throughwebPreferences.additionalArgumentsand parses it fromprocess.argvin the preload, preservingwindow.electron.versionas a string without any IPC round-trip.sendSyncand assert the exposedbasePathandversionvalues.Design decisions (preserve through rebases)
APP_VERSION_ARG_PREFIXinwindow.tsandpreload.ts— keeps the deletion focused without introducing a shared module for one string.basePathremainsfile://+path.join(process.resourcesPath, 'dist')with no trailing slash — the Expo bundle expects split asset paths to start with their own slash.versionis sourced only fromapp.getVersion()in the main process — Electron'sappobject is not available inside the preload.Test plan
pnpm ts:checkpnpm lint(exited 0; reported warnings, no errors)pnpm testpnpm run test:preloadprintspreload bridge assertions passedas part ofpnpm testgetBasePathSync/getAppVersionSyncreferences remain undersrc/window.tsimportsapp🤖 Generated with Claude Code