fix #268: park evaluations as Waiting when org has no eval-capable worker#269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Queued(sometimes forever, when only build-only workers were connected). It now parks asWaiting + Workers { connected_workers: 0 }immediately, mirroring the existingNoCachegate.org_has_eval_capable_worker_registration+park_if_no_workers+unpark_no_workers_for_org, wires them intoapply_trigger, the manual/projects/{org}/{project}/evaluateendpoint, and the worker register/patch endpoints.decide_pre_build_targetto count eval-capable connected workers rather than total and closes the runtime gap where a connected build-only worker left a Queued eval stranded with no possible eval-side progress.