fix: avoid JSON import attributes in dist - #24
Merged
Conversation
The published dist imported the bundled schema JSON with
`with { type: 'json' }`, which older consumer bundlers (e.g.
wrangler 3's pinned esbuild 0.17) cannot parse. The gen step now
emits the schema as a generated TS module (`src/generated/schema.ts`)
and the runtime imports that instead; the raw JSON is still shipped
and exported at `./schema/v1`.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0177Rm5YYW6CxrGeABjazVrz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The published
dist/index.jsimported the bundled schema JSON withwith { type: 'json' }, which older consumer bundlers (e.g. wrangler 3's pinned esbuild 0.17) cannot parse — the platform's API worker build fails on@wavekat/flow-schema@0.0.2.The gen step now emits the schema as a generated TS module (
src/generated/schema.ts) and the runtime imports that instead of the JSON file. The raw JSON is still bundled and exported at./schema/v1, so that consumer surface is unchanged.Verified:
gen(no drift),test(79 passing),build— dist contains no import attributes.🤖 Generated with Claude Code
https://claude.ai/code/session_0177Rm5YYW6CxrGeABjazVrz