Slash command menu working. by abhishekp106 · Pull Request #9358 · warpdotdev/warp

abhishekp106 · 2026-04-29T03:07:37Z

Description

Adds the new slash command menu for cloud mode v2.

https://www.loom.com/share/12c523ae66ca4e26b2d2ef46fdbcb035

Testing

See loom.

abhishekp106 · 2026-04-29T03:07:51Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

oz-for-oss · 2026-04-29T03:09:08Z

@abhishekp106

I'm starting a first review of this pull request.

You can follow along in the session on Warp.

I completed the review and posted feedback on this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

I completed the review and posted feedback on this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss

Overview

This PR adds a Cloud Mode V2 slash-command menu, including a new floating view, zero-state grouping for commands/skills/prompts, compact slash-command item rendering, and routing of keyboard acceptance/navigation to the new view when composing in Cloud Mode V2.

Concerns

The new click handler in CloudModeV2SlashCommandView::rebuild_from_results captures and moves an unused weak handle, which makes the callback fail the renderer's Fn requirement and blocks compilation.

Verdict

Found: 1 critical, 0 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss · 2026-04-29T03:12:47Z

+                item,
+                cmd_or_ctrl_enter: false,
+            });
+            let _ = weak_handle;


🚨 [CRITICAL] This let _ = weak_handle; moves the captured WeakViewHandle out of the click closure, so the closure is only FnOnce and cannot satisfy QueryResultRenderer::new's Fn bound or be reused for every renderer. Remove the unused weak-handle capture/field, or create a fresh clone per renderer if the callback needs it.

oz-for-oss

Overview

This PR adds a Cloud Mode V2 slash-command menu, new sectioned zero-state results for commands/skills/prompts, compact slash-command item rendering, and routes keyboard acceptance/navigation to the new menu while composing.

Concerns

The new cloud-mode view currently captures and moves weak_handle inside its click callback, which makes the callback incompatible with the Fn callback expected by QueryResultRenderer::new and reused for each renderer.
The shared slash-command data source is switched to compact/v2 behavior whenever CloudModeInputV2 is enabled, even though the regular inline slash menu still uses the same handle outside cloud-mode composing.
Security pass: no security-specific findings in the changed lines.

Verdict

Found: 1 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss · 2026-04-29T03:13:40Z

+                item,
+                cmd_or_ctrl_enter: false,
+            });
+            let _ = weak_handle;


🚨 [CRITICAL] let _ = weak_handle; moves the captured handle out of the click closure, so the closure is FnOnce while QueryResultRenderer::new requires an Fn and this same callback is reused for every renderer; remove this capture or clone per renderer.

oz-for-oss · 2026-04-29T03:13:40Z

+                terminal_view_id,
+            };
+            if FeatureFlag::CloudModeInputV2.is_enabled() {
+                SlashCommandDataSource::for_cloud_mode_v2(args, ctx)


⚠️ [IMPORTANT] This switches the shared slash_command_data_source to compact/v2 rendering for every slash menu whenever the flag is enabled, but the regular inline slash menu still receives this handle outside is_cloud_mode_input_v2_composing; keep the default source for the inline view or create a separate v2 source for CloudModeV2SlashCommandView.

liliwilson

Sweet!

A few things I am noticing while playing around:

Inserting a skill into the input + hitting enter doesn't kick off a cloud agent
Inserting a saved prompt into the input renders what I think is the saved prompt card at the top of the screen

- Some of the slash commands don't work and then prevent you from opening the command menu again (e.g. `/prompts`) - might just be some missing plumbing

liliwilson · 2026-04-29T07:52:40Z

    pub terminal_view_id: EntityId,
 }

 pub struct SlashCommandDataSource {


(Non-blocking) This is somewhat of a preexisting bug, but could we add something like an allowed_commands filter here that filters out commands that don't make sense in this cloud input view?

Thinking of things like /create-environment, /cloud-agent, /compact, /cost, /export..., /fork, /queue, /remote-control, /rewind

just did this here because there's a bunch of commands that don't apply and making the correct UI behavior happen is extra work!

We also should eventually not show /fork and a bunch of others at the beginning of a conversation too

My list is slightly different than yours, but lmk if there's something that you didn't expect!

Looks good to me

liliwilson · 2026-04-29T08:14:35Z

+    }
+}
+
+fn next_selectable_browsing_idx(


nit: can we genericify this fn and the next one?

liliwilson · 2026-04-29T08:15:31Z

+#[allow(dead_code)]
+fn _icon_size() -> f32 {
+    ICON_SIZE
+}
+
+#[allow(dead_code)]
+fn _icon_to_text_gap() -> f32 {
+    ICON_TO_TEXT_GAP
+}


nit: no longer needed?

abhishekp106 · 2026-04-29T18:25:53Z

All of these are fixed now! Was a little sloppy with Q&A - I noted all of these yesterday but forgor when I logged on late.

liliwilson

Will be good to get this in people's hands on dogfood!

liliwilson · 2026-04-29T21:41:42Z

    description: "Start a new conversation",
    icon_path: "bundled/svg/oz.svg",
-    availability: Availability::AI_ENABLED,
+    availability: Availability::AI_ENABLED.union(Availability::NOT_CLOUD_AGENT),


Ooh, nice that we can reuse this!

liliwilson · 2026-04-29T21:47:06Z

    pub terminal_view_id: EntityId,
 }

 pub struct SlashCommandDataSource {


Looks good to me

liliwilson · 2026-04-29T21:58:47Z

    slash_command_data_source: ModelHandle<SlashCommandDataSource>,
+    include_skills: bool,
+    include_saved_prompts: bool,
+    compact_layout: bool,


nit: can we call this is_cloud_mode_v2 to match the other one and pass that into a single constructor?

For now we might not even need separate include_skills and include_saved_prompts bools since they all just boil down to is_cloud_mode_v2

Done — consolidated into a single is_cloud_mode_v2 field with one new(..., is_cloud_mode_v2: bool) constructor.

Adds the new slash command menu for cloud mode v2. https://www.loom.com/share/12c523ae66ca4e26b2d2ef46fdbcb035  See loom.

cla-bot Bot added the cla-signed label Apr 29, 2026

abhishekp106 mentioned this pull request Apr 29, 2026

Slash command menu sidecar. #9359

Merged

abhishekp106 requested a review from liliwilson April 29, 2026 03:08

oz-for-oss Bot reviewed Apr 29, 2026

View reviewed changes

abhishekp106 force-pushed the abhishek/slash-command-menu branch 2 times, most recently from 21bc4dc to a9aebec Compare April 29, 2026 03:32

abhishekp106 mentioned this pull request Apr 29, 2026

Enabled cloud mode input v2 on dogfood. #9364

Merged

liliwilson reviewed Apr 29, 2026

View reviewed changes

abhishekp106 added 13 commits April 29, 2026 14:29

Slash command menu roughly working

bae3ac5

compact layout for description text

a0fef9b

Fix minor UI nits

8fadfd5

Scrolling by arrow key works

77066d4

remove comments

80372b1

robot feedback

b6ce956

fixed saved prompt card

f3243a6

Fix skills not being handled by correct path

0e78149

Remove slash commands that do not apply

08c3a30

Still working through the slash command menu

7522949

Various fixes

67bf0da

Remove comments

b5d9a29

Fmt

d8daf72

abhishekp106 force-pushed the abhishek/slash-command-menu branch from 4066eb6 to d8daf72 Compare April 29, 2026 18:38

abhishekp106 requested a review from liliwilson April 29, 2026 18:41

lili minor comments

0e94825

abhishekp106 mentioned this pull request Apr 29, 2026

Introduce /harness, /host and /environment slash commands to new cloud mode input. #9482

Merged

1 task

liliwilson approved these changes Apr 29, 2026

View reviewed changes

condense flags

77426b5

abhishekp106 merged commit e058136 into master Apr 29, 2026
26 checks passed

abhishekp106 deleted the abhishek/slash-command-menu branch April 29, 2026 23:48

abhishekp106 mentioned this pull request Apr 30, 2026

Hide host selector menu if no default host is present. #9523

Merged

1 task

Conversation

abhishekp106 commented Apr 29, 2026

Description

Testing

Uh oh!

abhishekp106 commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

oz-for-oss Bot Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

oz-for-oss Bot Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oz-for-oss Bot Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

liliwilson left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abhishekp106 commented Apr 29, 2026

Uh oh!

liliwilson left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abhishekp106 Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

abhishekp106 commented Apr 29, 2026 •

edited

Loading

oz-for-oss Bot commented Apr 29, 2026 •

edited

Loading

abhishekp106 Apr 29, 2026 •

edited

Loading