Skip to content

Migrate agent management view to use new AgentConversationEntry abstraction.#10194

Open
zachbai wants to merge 1 commit intomasterfrom
zb/migrate-mgmt-view
Open

Migrate agent management view to use new AgentConversationEntry abstraction.#10194
zachbai wants to merge 1 commit intomasterfrom
zb/migrate-mgmt-view

Conversation

@zachbai
Copy link
Copy Markdown
Contributor

@zachbai zachbai commented May 5, 2026

Description

Migrate agent management view to use AgentConversationEntry. ConversationOrTask is finally cleaned up in the next PR.

@cla-bot cla-bot Bot added the cla-signed label May 5, 2026
Copy link
Copy Markdown
Contributor Author

zachbai commented May 5, 2026

@zachbai zachbai marked this pull request as ready for review May 5, 2026 22:30
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 5, 2026

@zachbai

I'm starting a first review of this pull request.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR migrates the agent management view and details panel to consume AgentConversationEntry for rendering, open actions, copy-link handling, and details data construction.

Concerns

  • The management-card refactor drops the existing session expired/unavailable label, so disabled task rows no longer explain why they cannot be opened.
  • This is a user-visible management-view change, but the PR description does not include screenshots or a video. For faster review, please upload screenshots or a video of the feature working end to end.

Verdict

Found: 0 critical, 2 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

.with_child(Expanded::new(1., title_text.finish()).finish());

let mut time_and_avatar = Flex::row()
let time_and_avatar = Flex::row()
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [IMPORTANT] This removes the expired/unavailable session label that explained why a task row cannot be opened; keep an equivalent status indicator in the AgentConversationEntry rendering path before dropping the old label.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems like a good call

.with_child(Expanded::new(1., title_text.finish()).finish());

let mut time_and_avatar = Flex::row()
let time_and_avatar = Flex::row()
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems like a good call

@zachbai zachbai force-pushed the zb/migrate-list-view branch from 093ac2a to 9f13cec Compare May 5, 2026 23:26
@zachbai zachbai force-pushed the zb/migrate-mgmt-view branch from 56c0a01 to 249c840 Compare May 5, 2026 23:26
@zachbai zachbai force-pushed the zb/migrate-list-view branch from 9f13cec to 4f69792 Compare May 6, 2026 00:58
@zachbai zachbai force-pushed the zb/migrate-mgmt-view branch from 249c840 to bdbcb91 Compare May 6, 2026 00:58
Base automatically changed from zb/migrate-list-view to master May 6, 2026 02:36
@zachbai zachbai force-pushed the zb/migrate-mgmt-view branch from bdbcb91 to 0026555 Compare May 6, 2026 02:36
@zachbai zachbai force-pushed the zb/migrate-mgmt-view branch from 0026555 to e972641 Compare May 6, 2026 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants