fix: prevent Codex tab crash#10192
Draft
oz-for-oss[bot] wants to merge 3 commits intomasterfrom
Draft
Conversation
Co-Authored-By: Dhruvilkumar Ashokbhai Chodvadiya <50516925+dhruvac29@users.noreply.github.com>
Co-Authored-By: Sathvik Vangavolu <113149539+vikvang@users.noreply.github.com>
Co-Authored-By: Oz <oz-agent@warp.dev> Co-Authored-By: Sathvik Vangavolu <113149539+vikvang@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10189
Description
Linked Issue
ready-to-specorready-to-implement.Screenshots / Videos
Not applicable; this is a launch-path crash fix.
Testing
cargo fmt --all -- --checkCARGO_BUILD_JOBS=1 cargo clippy --workspace --exclude warp_completer --all-targets --tests -- -D warningsCARGO_BUILD_JOBS=1 cargo clippy -p warp_completer --all-targets --tests -- -D warningsCARGO_BUILD_JOBS=1 cargo test -p warp ai::execution_profiles::profiles::tests -- --nocapture; the sandbox killed thewarplib test compile with SIGKILL before tests ran.Agent Mode
CHANGELOG-BUG-FIX: Fixed a crash when opening a new Codex tab by avoiding mutation of the shared default execution profile and preventing unsupported Codex status updates from toggling rich input.