Update STAKEHOLDERS: add Andy to bootstrap, add command-signatures-v2#10161
Merged
Update STAKEHOLDERS: add Andy to bootstrap, add command-signatures-v2#10161
Conversation
The bootstrap paths that Aloke referenced are the OS bootstrap scripts (script/linux/bootstrap, script/macos/bootstrap, script/windows/bootstrap.ps1) from PR #9669, not the app-level bootstrap.rs and bundled/bootstrap/ paths. Co-Authored-By: Oz <oz-agent@warp.dev>
Per Aloke's recommendation, add script/linux/bootstrap, script/macos/bootstrap, and script/windows/bootstrap.ps1 with @vorporeal @zachbai @alokedesai @bnavetta @acarl005 as stakeholders (matching the files changed in PR #9669). Co-Authored-By: Oz <oz-agent@warp.dev>
Contributor
1 task
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR updates .github/STAKEHOLDERS with ownership entries for command-signatures-v2 and bootstrap scripts.
Concerns
- The bootstrap ownership change does not match the stated target: the existing app bootstrap entries remain unchanged, so
@acarl005will not be selected for/app/src/terminal/bootstrap.rsor/app/assets/bundled/bootstrap/.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| # Command signatures v2 | ||
| /command-signatures-v2/ @zachbai | ||
|
|
||
| # OS-level bootstrap scripts |
Contributor
There was a problem hiding this comment.
/script/*/bootstrap paths, but the stated bootstrap targets are the existing /app/src/terminal/bootstrap.rs and /app/assets/bundled/bootstrap/ entries, which remain @zachbai-only; add @acarl005 to those entries instead or clarify that this PR is only for OS bootstrap scripts.
captainsafia
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Andy as a stakeholder for bootstrap scripts, and ZB for command-signatures-v2