[REMOTE-1370] Phase 2a: taskGitCredentials schema, query, and AIClient#10152
Merged
jasonkeung merged 2 commits intomasterfrom May 5, 2026
Merged
[REMOTE-1370] Phase 2a: taskGitCredentials schema, query, and AIClient#10152jasonkeung merged 2 commits intomasterfrom
jasonkeung merged 2 commits intomasterfrom
Conversation
- Add taskGitCredentials types to schema.graphql (verified against staging) and add to clientQueries allowlist in client-schema.ts - Add task_git_credentials.rs GraphQL query file (cynic) following the task_secrets pattern - Add GitCredential struct and get_task_git_credentials to AIClient trait with a ServerApi implementation Co-Authored-By: Oz <oz-agent@warp.dev>
This was referenced May 5, 2026
Contributor
|
I'm starting a first review of this pull request. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
Adds the client-side GraphQL schema/query plumbing and AIClient method for fetching task git credentials. The implementation follows the existing taskSecrets pattern and no caller behavior changes in this PR.
Concerns
- No blocking correctness concerns found in the changed lines.
- The merge dependency on the server-side Phase 1 rollout remains an operational gate outside this code review.
Security
- One non-blocking hygiene issue: avoid deriving Debug on the app-level credential type so tokens are not accidentally emitted by debug logging.
Verdict
Found: 0 critical, 0 important, 1 suggestions
Approve with nits
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Co-authored-by: oz-for-oss[bot] <277970191+oz-for-oss[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
First half of Phase 2 of REMOTE-1370. Adds the GraphQL plumbing for `taskGitCredentials` so the driver can call it in the next PR.
Changes:
No behaviour change — nothing calls `get_task_git_credentials` yet; that's in the follow-on PR.
schema.graphql approach: `yarn generate -p staging` was run to verify the new types, but the output was not committed wholesale because the current staging server also has other unrelated schema changes (removed `freeAvailableModels`, new `VOYAGE_4_512` EmbeddingConfig variant, etc.) that are out of scope and would break existing Rust bindings. Instead, only the `taskGitCredentials` types were cherry-picked — the field names, nullability, and doc comments were verified to be identical to what the server generates.
Warp-server staging is deployed with the new query.
Followed by: #10153.
Linked Issue
Linear: REMOTE-1370
Testing
Agent Mode
Conversation: https://staging.warp.dev/conversation/e16dc3e2-8e2f-4499-8c9b-59b200e17c50
Co-Authored-By: Oz oz-agent@warp.dev