test(evals): confirm the eval gate triggers, and show output when it fails#8
Merged
Merged
Conversation
Opened to confirm the tastytrade-mcp eval gate triggers on a change confined to evals/, and to make the gate useful when it does fail. validate_local.sh discarded both runs with >/dev/null, so a CI failure printed only a task name and the two reward values. Diagnosing meant reproducing it locally. The oracle, verifier, and negative-control output now go to files inside the existing $work tempdir and are printed, indented and tail-limited, only on failure. Passing runs are unchanged. Verified by breaking one oracle on purpose: the run reported 11 passed, 1 failed and surfaced the real cause plus the resulting cascade (oracle exited non-zero, so no answer.json existed for the verifier to read). Restored, 12 passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two purposes, one file changed.
1. Confirm the trigger
This PR touches only
tastytrade-mcp/evals/validate_local.sh. If thetastytrade-mcpworkflow runs and its Validate eval task verifiers step executes, thepathsfilter is confirmed to fire on eval-only changes. If theharbor-mcpjobs stay absent, per-subdirectory scoping is confirmed in the same run.For reference, the step already ran green in #7, which touched
tastytrade-mcp/README.md:This isolates it to an eval file specifically.
2. Make the gate useful when it fails
validate_local.shdiscarded both runs with>/dev/null 2>&1, so a failure printed only a task name and two reward values:That is enough to know something broke and nothing about what. Diagnosing meant reproducing locally. The oracle, verifier, and negative-control output now go to files inside the existing
$worktempdir and print, indented and tail-limited, only on failure. Passing runs are byte-identical.Verified by breaking one oracle deliberately:
The cascade is visible: the oracle exited non-zero, so no
answer.jsonexisted for the verifier to read. Restored,12 passed, 0 failed.The negative control was already sound and is untouched: it still requires reward 1 from the oracle and reward 0 from an empty answer, so a verifier that blindly awards 1 fails.