ci(v3): attach artifacts to nightly releases - #5880
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe nightly v3 release workflow now dispatches ChangesRelease artifact dispatch
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the v3 nightly release workflow to explicitly dispatch the existing Release v3 workflow after a nightly tag is created, ensuring each nightly GitHub release receives the full set of desktop binaries, checksums, and provenance artifacts.
Changes:
- Add an explicit
gh workflow run release-v3.ymldispatch step after successful nightly tagging. - Pass the created tag and derived
pre_releaseflag into theRelease v3workflow inputs. - Surface the hand-off status in the nightly workflow step summary.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| run: | | ||
| tag="${{ steps.release.outputs.release_tag }}" | ||
| pre_release=false | ||
| if [[ "$tag" == *-* ]]; then | ||
| pre_release=true | ||
| fi | ||
|
|
||
| gh workflow run release-v3.yml \ | ||
| --repo "${{ github.repository }}" \ | ||
| --ref master \ | ||
| -f tag="$tag" \ | ||
| -f pre_release="$pre_release" \ | ||
| -f draft=false | ||
| echo "dispatched=true" >> "$GITHUB_OUTPUT" | ||
| echo "Dispatched Release v3 for $tag" |
Summary
Release v3after the nightly release task creates a tagFixes #5876
Why
The nightly workflow uses
GITHUB_TOKENto create tags. GitHub intentionally does not trigger a second workflow from those tag pushes, so beta.2 received a GitHub release with no downloadable desktop artifacts.Validation
git diff --checkactionlint .github/workflows/nightly-release-v3.ymlreports only pre-existing diagnostics (theactions/setup-go@v4version and existing shellcheck style warnings); the new dispatch block has no actionlint finding.The dispatched
Release v3workflow remains the single publisher of binaries, SHA256SUMS, and provenance.Summary by CodeRabbit