Skip to content

chore: remove the root go.work workspace file - #5814

Merged
leaanthony merged 2 commits into
masterfrom
chore/remove-go-work
Jul 26, 2026
Merged

chore: remove the root go.work workspace file#5814
leaanthony merged 2 commits into
masterfrom
chore/remove-go-work

Conversation

@taliesin-ai

@taliesin-ai taliesin-ai commented Jul 26, 2026

Copy link
Copy Markdown
Collaborator

What

Removes the root go.work workspace, and the CI plumbing that only existed to support it.

After the webview2 fold (#5711) the workspace covered a single module, ./v3, and every CI workflow already sets GOWORK: "off", so it only ever affected local development. There it did more harm than good:

  • An active workspace shadows the standalone example modules nested under v3/. That is why v3/examples/mac-window-tabs has to force GOWORK: "off" in two Taskfiles: without it, binding generation finds 0 services and go mod tidy targets v3 instead.
  • It forced build-and-test-v3.yml to run go work use . on each generated template project so Go 1.25 workspace mode would not reject it.

Contributors who want a workspace can still create one; it is now gitignored so it stays local.

Changes

  • delete go.work and go.work.sum
  • build-and-test-v3.yml: drop the go.work / go.work.sum path filters, both cache keys, and the go work use . step
  • cross-compile-test-v3.yml: drop the same filters and cache key
  • .gitignore: ignore go.work and go.work.sum
  • mac-window-tabs Taskfiles: keep GOWORK: "off" (still correct defensively, for contributors with a local workspace) but reword the comments, which referred to a root workspace that no longer exists

Second commit, while in the same lines: the webview2/** path filters and webview2/go.sum cache entries in both workflows have been dead since the module was folded into v3/internal/webview2. Removed.

Verification

  • go build ./... in v3/ with no workspace active: clean
  • a module created at the repo root builds with nothing to reject it, which is what the removed go work use . step was compensating for
  • both workflows and both Taskfiles parse as YAML
  • no go work invocation remains anywhere in the repo

https://claude.ai/code/session_01FigQqUQbNu9ngE4a2CSNm8

Summary by CodeRabbit

  • Chores

    • Improved automated build and test workflow targeting for v3 changes.
    • Updated caching configuration to make validation runs more focused and reliable.
    • Added local Go workspace files to ignored files.
  • Documentation

    • Clarified workspace and standalone-module guidance in macOS window tab example tasks.
    • Improved instructions for running example build and development tasks directly or through repository-level commands.

After the webview2 fold (#5711) the workspace covered a single module,
./v3, and every CI workflow already sets GOWORK=off, so it only affected
local development. There it did more harm than good: an active workspace
shadows the standalone example modules nested under v3/, which is why the
mac-window-tabs Taskfiles force GOWORK=off, and it forced CI to run
`go work use .` on generated template projects so Go 1.25 workspace mode
would not reject them.

- delete go.work and go.work.sum
- drop the go.work path filters and cache keys from the v3 build and
  cross-compile workflows
- drop the `go work use .` step, which has nothing left to register
- gitignore go.work/go.work.sum so local workspaces stay local

Verified with `go build ./...` in v3 with no workspace active, and by
building a module created at the repo root to confirm nothing rejects it.

Claude-Session: https://claude.ai/code/session_01FigQqUQbNu9ngE4a2CSNm8
The webview2 module directory has not existed since it was folded into
v3/internal/webview2 (#5711), so the `webview2/**` path filters never
match and `webview2/go.sum` never contributes to the Go build cache key.

Claude-Session: https://claude.ai/code/session_01FigQqUQbNu9ngE4a2CSNm8
@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 33f31e1f-cd29-4336-b1da-eda9f3c7bb59

📥 Commits

Reviewing files that changed from the base of the PR and between e63d2bd and 3426a27.

⛔ Files ignored due to path filters (2)
  • go.work is excluded by !**/*.work
  • go.work.sum is excluded by !**/*.sum
📒 Files selected for processing (5)
  • .github/workflows/build-and-test-v3.yml
  • .github/workflows/cross-compile-test-v3.yml
  • .gitignore
  • v3/examples/mac-window-tabs/Taskfile.yml
  • v3/examples/mac-window-tabs/build/Taskfile.yml
💤 Files with no reviewable changes (2)
  • .github/workflows/cross-compile-test-v3.yml
  • .github/workflows/build-and-test-v3.yml

Walkthrough

V3 CI workflows now use V3-specific path filters and Go cache inputs. Template builds no longer register generated projects with Go workspaces. Local go.work files are ignored, and example task comments explain forced workspace disabling.

Changes

V3 workspace and CI behavior

Layer / File(s) Summary
Narrow V3 workflow scope and caching
.github/workflows/build-and-test-v3.yml, .github/workflows/cross-compile-test-v3.yml
Workflow triggers and Go cache dependencies now focus on V3 files and the workflow definitions.
Simplify generated template builds
.github/workflows/build-and-test-v3.yml
Template testing no longer runs go work use . before wails3 build.
Handle local Go workspaces
.gitignore, v3/examples/mac-window-tabs/Taskfile.yml, v3/examples/mac-window-tabs/build/Taskfile.yml
Local Go workspace files are ignored, and task comments document forced workspace disabling.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested labels: templates

Poem

I’m a rabbit with a tidy burrow,
Go work files tucked away from view.
V3 builds hop on their own path,
Templates bloom without workspace glue.
CI follows the freshest trail—
And every task knows what to do.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is detailed, but it omits the required Fixes # issue link and the template's type/test/checklist sections. Add a linked issue (Fixes #...), fill in the type-of-change and testing sections, and complete the checklist/test configuration.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: removing the root go.work workspace file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-go-work

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@leaanthony leaanthony left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally: v3 builds with no workspace active, and a module created at the repo root builds without workspace rejection (what the removed go work use . step was compensating for). CI template builds are the real test and are green so far.

The webview2 filter cleanup in the second commit is dead-reference removal from the same lines, no behaviour change.

@leaanthony
leaanthony merged commit 2a4e177 into master Jul 26, 2026
72 checks passed
@leaanthony
leaanthony deleted the chore/remove-go-work branch July 26, 2026 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants