Skip to content

docs(repo): add PRP-33 batch-runner-mvp (#277)#279

Merged
w7-mgfcode merged 1 commit into
devfrom
docs/prp-33-batch-runner-mvp
May 20, 2026
Merged

docs(repo): add PRP-33 batch-runner-mvp (#277)#279
w7-mgfcode merged 1 commit into
devfrom
docs/prp-33-batch-runner-mvp

Conversation

@w7-mgfcode
Copy link
Copy Markdown
Owner

Summary

Lands the PRP doc for the Batch Runner MVP — the unblocker for the four downstream Full-Version INITIALs (parallel-execution, priority-queue, export-and-retry, champion-and-heatmap) merged via #278.

Doc-only PR. The implementation lands in a follow-up execution PR.

Refs #277.

Drift edits applied vs INITIAL-batch-runner-mvp.md

The PRP draft was reviewed against its source INITIAL (PRPs/INITIAL/INITIAL-batch-runner-mvp.md) and found to be MINOR DRIFT. Three edits applied before landing:

  1. Locked sample_size derivation to Option (a) — computed inside the batch slice from fold_metrics. Option (b) (extending jobs/service.py:_shape_backtest_result) is now explicitly REJECTED in the Confidence-Score section because it would violate the vertical-slice no-cross-import rule and the off-limits boundary declared in § "What → Success Criteria".
  2. Added test_service_emits_lifecycle_events to the Test Plan unit suite — asserts the five batch.{created,item_started,item_completed,item_failed,completed} structlog event names emit in order and that every event payload carries a request_id field for log correlation.
  3. Rounded out _expand_scope unit coverage — added explicit test entries for region, category, and all BatchScope.kind values (PRP previously only enumerated manual and top_revenue).

Out of scope for this PR

  • No code under app/features/batch/, no Alembic migration, no frontend code — those land in the implementation PR per PRP execution.
  • No changes to app/features/jobs/, app/features/forecasting/, or tests/test_e2e_demo.py — the PRP declares these off-limits.

Test plan

  • PRP file renders correctly (review the diff for the three edit spots).
  • Commit message accepted by .claude/hooks/check-commit-format.sh (uses repo scope; already in allow-list).
  • Reviewer verifies the three drift edits read as intended.

Note: .claude/rules/commit-format.md is gitignored, so the PRP's "Task 1 — Pre-add batch to commit-format scope allow-list" step runs locally on whichever workstation executes the implementation PRP; it cannot ride along in this PR.

Adds the PRP for the batch-runner MVP, the unblocker for the four downstream
batch INITIALs landed in #278 (parallel-execution, priority-queue, export-and-retry,
champion-and-heatmap). Resolves three minor drift items vs INITIAL-batch-runner-mvp.md:
locks sample_size derivation to Option (a) inside the batch slice (Option (b) rejected
as a vertical-slice violation), adds a test_service_emits_lifecycle_events test asserting
the five batch.* structlog event names + request_id correlation, and rounds out
_expand_scope unit coverage to every BatchScope.kind (manual, region, category,
top_revenue, all).
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 20, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a1707858-7942-42b5-afc1-328b4bf695a0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/prp-33-batch-runner-mvp

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @w7-mgfcode, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@w7-mgfcode w7-mgfcode merged commit df90d22 into dev May 20, 2026
8 checks passed
@w7-mgfcode w7-mgfcode deleted the docs/prp-33-batch-runner-mvp branch May 20, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant