Require HMAC comparison to be constant time#553
Merged
Conversation
twiss
approved these changes
Mar 26, 2026
twiss
left a comment
twiss
left a comment
Member
There was a problem hiding this comment.
Thanks! I believe this is already the case in most implementations and IMHO it makes sense to mandate this.
twiss
changed the title
github-actions Bot
added a commit
that referenced
this pull request
Mar 26, 2026
SHA: da6a8b5 Reason: push, by twiss Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See CVE-2026-21713 https://nodejs.org/en/blog/vulnerability/march-2026-security-releases
Preview | Diff