Check the results of PTZ permission requests - #280
Open
eehakkin wants to merge 3 commits into
Open
Conversation
eehakkin
force-pushed
the
fix-ptz-permission-request-result-check
branch
from
May 4, 2021 21:04
fab4506 to
a3c00df
Compare
jan-ivar
requested changes
May 5, 2021
jan-ivar
approved these changes
Oct 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As stated in #279, the spec requests
{name: "camera", panTiltZoom: true}permissions but does not check whether the permissions were granted or denied. That is clearly not the intention.Preview | Diff
Preview | Diff