NavigationPreloadManager.setHeaderValue should reject invalid header values#1827
Merged
Merged
Conversation
…values This update adds validation for the header value in NavigationPreloadManager.setHeaderValue() to match the Fetch specification's "header value" definition. It now: 1. Normalizes the input value (stripping HTTP whitespace). 2. Rejects the promise with a TypeError if the value contains invalid bytes (including \r, \n, or \0). Fixes w3c#1000
Collaborator
Author
|
@monica-ch Will you review this? |
monica-ch
approved these changes
Jun 16, 2026
Member
|
Do we have tests for this as well? |
github-actions Bot
added a commit
to asleekgeek/ServiceWorker
that referenced
this pull request
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update adds validation for the header value in NavigationPreloadManager.setHeaderValue() to match the Fetch specification's "header value" definition. It now:
Fixes #1000
Preview | Diff