Skip to content

Update usages of module fetching html algorithms#1658

Open
nicolo-ribaudo wants to merge 3 commits into
w3c:mainfrom
nicolo-ribaudo:perform-the-fetch-hook-refactor
Open

Update usages of module fetching html algorithms#1658
nicolo-ribaudo wants to merge 3 commits into
w3c:mainfrom
nicolo-ribaudo:perform-the-fetch-hook-refactor

Conversation

@nicolo-ribaudo

@nicolo-ribaudo nicolo-ribaudo commented Oct 3, 2022

Copy link
Copy Markdown
Member

This updates this spec for whatwg/html#8264 and whatwg/html#8328.


Preview | Diff

@w3cbot

w3cbot commented Oct 3, 2022

Copy link
Copy Markdown

Ms2ger marked as non substantive for IPR from ash-nazg.

@domenic domenic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Although I don't have merge rights, I hope the editors can merge this soon.

They should delay until ~24 hours from now to make sure the HTML exported definitions get indexed.

@triple-underscore

Copy link
Copy Markdown

I checked the diff and found that there is one instance of "Asynchronously complete these steps" (in the clause "If maxScopeString is null or scopeString does not start with maxScopeString, then:") which is not replaced with "Invoke processCustomFetchResponse".

@nicolo-ribaudo

Copy link
Copy Markdown
Member Author

Thanks @triple-underscore, updated!

@nicolo-ribaudo

Copy link
Copy Markdown
Member Author

Please don't merge this yet, until whatwg/html#8412 is merged.

@domenic

domenic commented Jan 24, 2025

Copy link
Copy Markdown
Contributor

@yoshisatoyanagisawa now that you are active, it would be great to get this merged :)

@yoshisatoyanagisawa

Copy link
Copy Markdown
Collaborator

Hi! I recently become an editor and am happy to review the PR :)
Can I ask the original author to resolve the merge conflicts if possible?

@nicolo-ribaudo

Copy link
Copy Markdown
Member Author

Yes, I'll get to it next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants