Bugfix: Column width regression (since C#14 refactor & cleanup)#386
Open
DanielTrommel wants to merge 4 commits into
Open
Bugfix: Column width regression (since C#14 refactor & cleanup)#386DanielTrommel wants to merge 4 commits into
DanielTrommel wants to merge 4 commits into
Conversation
Signed-off-by: Daniël Trommel <d.s.trommel@gmail.com>
667e2eb to
6177479
Compare
…nd back to a tab with a tableview, the vertical gridlines form the rows would be misaligned from the header. The call in the OnLoaded fixes this.
6177479 to
db45f31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Using the latest version, I noticed that vertical grid lines (header <> rows) are mis-aligned when (tab-based) navigating away and later returning back to a TableView, which has columns for which I did not specify Widths.
TableView-GridLinesIssue.mp4
Steps to Reproduce:
In the
SampleAppproject:in method
ExampleModelColumnsHelper.OnAutoGeneratingColumns()comment out all lines that set the column widths, e.g.:In
GridLinesPage.xamlreplace lines 19-21 (the tableview component) with this code:Switch the TableView lib project to commit bf62080 or newer
Run the application, and go to the Gridlines example; switch to the "reproduction" tab, and back to the tab with the TableView, and you should see mis-aligned columns
Expected behavior:
Grid lines should always align, ideally with auto-resizing for columns for which no Width was provided.
Contribution:
TableView-GridLines-AutoResize.mp4