-
Notifications
You must be signed in to change notification settings - Fork 95
Launch installed CLI directly with bundled Bun (Fixes #2603) #2610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
3b3e532
Launch installed CLI directly with bundled Bun (Fixes #2603)
acoliver 3f52cce
Satisfy strict shell lint for native launcher
acoliver 99f2d2e
Harden installed launcher resolution and smoke coverage
acoliver ada4060
Normalize Windows tar listings in launcher smoke
acoliver 912dad1
Harden Windows launcher verification
acoliver ecf3893
Merge main and harden Windows launcher smoke
acoliver 087526e
Resolve remaining launcher review findings
acoliver 7b81386
Fix Windows installed launcher verification
acoliver 5489db5
Preserve native Windows launcher status and lineage
acoliver b6bdf4e
Use policy-compliant Bun FFI loading
acoliver 624b526
Harden launcher review edge cases
acoliver 20f52d0
Satisfy launcher shell lint
acoliver b49f262
Harden installed launcher diagnostics
acoliver 0627da9
Increase Windows install timeout headroom
acoliver 67b51b1
Prefer cached Windows smoke installs
acoliver 2e84620
Harden launcher review contracts
acoliver 4ee5676
Harden prerelease and tar execution contracts
acoliver 1436f7b
Tighten launcher review boundaries
acoliver cdd6a6c
Close launcher ownership race windows
acoliver File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| name: 'Windows Installed Command (issue #2603)' | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - 'packages/cli/bin/**' | ||
| - 'packages/cli/package.json' | ||
| - 'packages/cli/scripts/install-native-launchers.cjs' | ||
| - 'package.json' | ||
| - 'package-lock.json' | ||
| - 'scripts/postinstall.cjs' | ||
| - 'scripts/tests/issue-2603-release-pack.cjs' | ||
| - 'scripts/tests/issue-2603-windows-probe.ts' | ||
| - 'scripts/tests/issue-2603-startup-benchmark.cjs' | ||
| - 'scripts/windows-installed-command-smoke.cjs' | ||
| - 'scripts/windows-installed-command-smoke/**' | ||
| - '.github/workflows/windows-installed-command.yml' | ||
| push: | ||
| branches: | ||
| - 'main' | ||
| paths: | ||
| - 'packages/cli/bin/**' | ||
| - 'packages/cli/package.json' | ||
| - 'packages/cli/scripts/install-native-launchers.cjs' | ||
| - 'package.json' | ||
| - 'package-lock.json' | ||
| - 'scripts/postinstall.cjs' | ||
| - 'scripts/tests/issue-2603-release-pack.cjs' | ||
| - 'scripts/tests/issue-2603-windows-probe.ts' | ||
| - 'scripts/tests/issue-2603-startup-benchmark.cjs' | ||
| - 'scripts/windows-installed-command-smoke.cjs' | ||
| - 'scripts/windows-installed-command-smoke/**' | ||
| - '.github/workflows/windows-installed-command.yml' | ||
| workflow_dispatch: | ||
|
|
||
| # Cancel superseded runs of this workflow for the same ref so that repeated | ||
| # pushes to a PR do not queue redundant Windows install smokes. | ||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| windows-installed-command: | ||
| runs-on: 'windows-latest' | ||
| # 60 min (root cause D): the smoke does real global/local/npm-exec | ||
| # installs plus a benchmark. 30 min was too tight when multiple installs | ||
| # ran back-to-back. All install timeouts are env-configurable and stay | ||
| # well under this job budget. | ||
| timeout-minutes: 60 | ||
| permissions: | ||
| contents: 'read' | ||
| steps: | ||
| - name: 'Checkout' | ||
| uses: 'actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8' # ratchet:actions/checkout@v5 | ||
| with: | ||
| fetch-depth: 1 | ||
|
|
||
| - name: 'Set up Node.js' | ||
| uses: 'actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e' # ratchet:actions/setup-node@v6 | ||
| with: | ||
| node-version-file: '.nvmrc' | ||
| cache: 'npm' | ||
|
|
||
| - name: 'Setup Bun' | ||
| uses: 'oven-sh/setup-bun@735343b667d3e6f658f44d0eca948eb6282f2b76' # ratchet:oven-sh/setup-bun@v2 | ||
| with: | ||
| bun-version-file: '.bun-version' | ||
|
|
||
| # Publish the absolute path to PowerShell 7 (pwsh.exe) so the smoke | ||
| # resolves it robustly under a constrained PATH. windows-latest ships | ||
| # pwsh but NOT legacy `powershell` on PATH, which previously caused | ||
| # every PowerShell-gated step to fail with ENOENT (run 29850614559). | ||
| - name: 'Export PowerShell 7 path' | ||
| shell: 'pwsh' | ||
| run: | | ||
| "PWSH_PATH=$((Get-Command pwsh).Source)" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append | ||
|
|
||
| - name: 'Install dependencies (npm ci)' | ||
| run: 'npm ci' | ||
|
|
||
| # The smoke runs the behavioral checks AND the startup benchmark (as a | ||
| # child process using the already-installed launcher + platform bun), so | ||
| # no separate benchmark step is needed. The benchmark is invoked with | ||
| # LLXPRT_BENCH_LAUNCHER/LLXPRT_BENCH_BUN so it never repacks or | ||
| # reinstalls — it reuses the install the smoke already proved. | ||
| - name: 'Run Windows installed-command behavioral smoke + benchmark' | ||
| run: 'node scripts/windows-installed-command-smoke.cjs' | ||
|
acoliver marked this conversation as resolved.
|
||
|
|
||
| # Upload the small diagnostic JSON written on failure (root cause I). | ||
| # Hosted runner temp vanishes post-job, so this small artifact (no | ||
| # node_modules) is how failures are debugged offline. Kept tiny. | ||
| - name: 'Upload diagnostic artifact on failure' | ||
| if: ${{ failure() }} | ||
| uses: 'actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02' # ratchet:actions/upload-artifact@v4 | ||
| with: | ||
| name: 'llxprt-win-smoke-diagnostic' | ||
| path: '${{ runner.temp }}/llxprt-win-smoke-diagnostic-*.json' | ||
| if-no-files-found: 'ignore' | ||
| retention-days: 7 | ||
|
acoliver marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.