Splitter component#679
Merged
Merged
Conversation
- update divider class for full height - improve storybook examples with new layout and descriptions.
- Enhanced gutter styles with rounded corners and focus-visible outlines. - Removed gutterColor prop from Props interface and related usages. - Cleaned up USplitter component by eliminating unused divider attributes. - Updated storybook examples to reflect changes.
| }, | ||
| }, | ||
| panel: { | ||
| base: "", |
| disabled: false, | ||
| stateKey: null, | ||
| stateStorage: "session", | ||
| step: 5, |
| }, | ||
| defaults: { | ||
| orientation: "horizontal", | ||
| gutterSize: 8, |
Collaborator
Author
There was a problem hiding this comment.
No need to add default values in config, because minSizes and maxSizes are possibly arrays, so they should be added into withDefaults same as modelValue
| }, | ||
| }, | ||
| defaults: { | ||
| orientation: "horizontal", |
Contributor
There was a problem hiding this comment.
better to have boolean vertical (false by default, that mean apply classes from horisontal)
- Changed orientation prop to vertical boolean for clearer semantics. - Updated related styles and computed properties to reflect the new vertical layout. - Adjusted storybook examples and tests to accommodate the new prop structure.
itsJohnnyGrid
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://ilevel.atlassian.net/jira/software/c/projects/VL/boards/11?selectedIssue=VL-279