feat(chart): allow InPlaceOrRecreate VPA updateMode#30
Merged
Conversation
The values schema enum permitted only Off/Initial/Recreate/Auto, so a consumer setting `verticalPodAutoscaler.updateMode: InPlaceOrRecreate` (VPA 1.5+/k8s 1.33+ in-place pod resize) failed schema validation and the Helm release went NotReady. The VPA template already passes updateMode through verbatim, so adding the enum value is the only change needed. Chart 0.3.1 -> 0.3.2 (chart-only; appVersion stays v2.0.4).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
InPlaceOrRecreateto theverticalPodAutoscaler.updateModeenum invalues.schema.json, bumps the chart0.3.1 → 0.3.2, and documents the mode invalues.yaml.Why
A consumer (wxs flux,
monitoring/silencer) setupdateMode: InPlaceOrRecreate(VPA 1.5+/k8s 1.33+ in-place pod resize) and the Helm upgrade failed schema validation:The VPA template already passes
updateModethrough verbatim (updateMode: {{ .Values.verticalPodAutoscaler.updateMode | quote }}), so the schema enum was the only gate. No template change.Notes
v2.0.4.helm lintpasses.chart.ymlpublishes0.3.2tooci://ghcr.io/vtmocanu/charts/silencer; the flux OCIRepository tag then bumps to0.3.2to consume it.🤖 Generated with Claude Code