Skip to content

Fix PinOne swallowing connect failures (zombie updater thread) #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsm174 merged 1 commit into from
Jul 6, 2026
Merged

Fix PinOne swallowing connect failures (zombie updater thread) #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/cab/out/pinone/PinOne.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,22 +159,19 @@ void PinOne::ConnectToController()
if (m_pinOneCommunication->CreateServer())
{
if (!m_pinOneCommunication->ConnectToServer())
{
Log::Warning(StringExtensions::Build("Unable to connect to PinOne on comport {0}", m_comPort));
return;
}
throw std::runtime_error(StringExtensions::Build("Unable to connect to PinOne on comport {0} after server creation", m_comPort));
}
else
{
Log::Warning(StringExtensions::Build("Unable to create PinOne server for comport {0}", m_comPort));
return;
throw std::runtime_error(StringExtensions::Build("Unable to create PinOne server for comport {0}", m_comPort));
}
}
}
catch (const std::exception& e)
{
std::string msg = StringExtensions::Build("A exception occurred while opening comport {0} for {1}.", m_comPort, GetName());
Log::Warning(msg);
throw;
}
}

Expand Down
Loading