design: analyse test spec model, propose type-based aontu structure#75
Merged
Conversation
Reverse-engineers the implicit entry schema currently defined only in typescript/test/runner.ts, documents the three-level struct/function/group/set model, and proposes declaring Entry/Group/Spec as aontu types so unification guards the corpus shape, centralises defaults, and makes fixtures/DEF first-class. Includes a migration plan gated on keeping the compiled build/test/test.json byte-equivalent. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fn6v25EtY7Kss941hkMhrn
Replaces the verify/fallback hedging with the actual aontu feature set from rjrodger/aontu docs: hide() (excludes from output -> keeps test.json byte-equivalent), close()/open() (closed structs -> the typo guard), *value defaults, | disjunction, x? optional fields, and [&:T] / &: map templates. Rewrites the schema sketch, migration steps, and open questions accordingly; remaining unknowns are now integration-specific. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fn6v25EtY7Kss941hkMhrn
Replaces the closed-disjunction "exactly one input mode" model with an adaptive base Entry: all fields optional and *-defaulted (closed only on field names for the typo guard), which each function refines to its own in/out shape through the &: template (Entry'). This tracks the runner's precedence semantics instead of forbidding field combinations, and suits aontu's additive unification (confirmed: no conditionals, no field interdependence, no comprehensions). Updates the schema sketch, adds 4.3.1 per-function adaptation, and reworks the shape/migration/buys/loose -ends sections accordingly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fn6v25EtY7Kss941hkMhrn
Companion artifact showing the proposed adaptive type structure in real aontu: base Entry/Group types (schema marks), test.jsonic wiring, the per-function Entry refinements, a worked getpath entry with its effective composed type and typo-guard cases, and the typed fixtures slot. Links it from TESTSPEC_MODEL.md. Reference only — not wired into the build. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fn6v25EtY7Kss941hkMhrn
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverse-engineers the implicit entry schema currently defined only in
typescript/test/runner.ts, documents the three-level
struct/function/group/set model, and proposes declaring Entry/Group/Spec
as aontu types so unification guards the corpus shape, centralises
defaults, and makes fixtures/DEF first-class. Includes a migration plan
gated on keeping the compiled build/test/test.json byte-equivalent.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01Fn6v25EtY7Kss941hkMhrn