deps: update ts/go deps; sort model JSON keys for byte-exact parity#10
Merged
Conversation
Update dependencies in both implementations: - Go: aontu/go -> v0.1.4 (release tag), multisource/go -> v0.3.1. - TS: memfs -> 4.57.8. (@types/node 26 is held back: it drops the worker_threads TransferListItem type that pino's thread-stream needs, which breaks the build.) Make the unified model output byte-for-byte identical across TS and Go. Go's encoding/json already sorts object keys, so the TS model producer now sorts them too (sortKeys in ts/src/producer/model.ts). Go disables encoding/json HTML escaping (marshalModel) so <, > and & are emitted literally as JSON.stringify does, and trims the encoder's trailing newline. Both use a two-space indent; arrays keep their order. Add parity tests in both languages (ts/test/parity.test.ts and go/parity_test.go) that assert the same expected byte string, and update AGENTS.md to record that the model JSON output is now byte-identical. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UgsNvRoZYcHm2YDovCUQTP
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update dependencies in both implementations:
worker_threads TransferListItem type that pino's thread-stream needs,
which breaks the build.)
Make the unified model output byte-for-byte identical across TS and Go.
Go's encoding/json already sorts object keys, so the TS model producer now
sorts them too (sortKeys in ts/src/producer/model.ts). Go disables
encoding/json HTML escaping (marshalModel) so <, > and & are emitted
literally as JSON.stringify does, and trims the encoder's trailing newline.
Both use a two-space indent; arrays keep their order.
Add parity tests in both languages (ts/test/parity.test.ts and
go/parity_test.go) that assert the same expected byte string, and update
AGENTS.md to record that the model JSON output is now byte-identical.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01UgsNvRoZYcHm2YDovCUQTP