Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 1 addition & 7 deletions vortex-compressor/src/compressor/cascade.rs
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ use vortex_array::arrays::fixed_size_list::FixedSizeListArraySlotsExt;
use vortex_array::arrays::listview::ListViewArraySlotsExt;
use vortex_array::arrays::listview::list_from_list_view;
use vortex_array::arrays::masked::MaskedArraySlotsExt;
use vortex_array::arrays::scalar_fn::AnyScalarFn;
use vortex_array::arrays::struct_::StructArrayExt;
use vortex_array::arrays::union::UnionArrayExt;
use vortex_array::arrays::union::UnionArraySlotsExt;
Expand Down Expand Up @@ -175,10 +174,6 @@ impl CascadingCompressor {
compress_ctx,
exec_ctx,
)?;
// TODO(connor): HACK TO SUPPORT L2 DENORMALIZATION!!!
if scheme_compressed.is::<AnyScalarFn>() {
return Ok(scheme_compressed);
}

// A constant extension array (that might be masked) is already in its terminal
// representation, and compressing the storage separately cannot do better.
Expand Down Expand Up @@ -321,8 +316,7 @@ impl CascadingCompressor {
let after_nbytes = compressed.nbytes();
let actual_ratio = (after_nbytes != 0).then(|| before_nbytes as f64 / after_nbytes as f64);

// TODO(connor): HACK TO SUPPORT L2 DENORMALIZATION!!!
let accepted = after_nbytes < before_nbytes || compressed.is::<AnyScalarFn>();
let accepted = after_nbytes < before_nbytes;

trace::record_winner_compress_result(
after_nbytes,
Expand Down
2 changes: 2 additions & 0 deletions vortex-tensor/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,5 @@ prost = { workspace = true }
[dev-dependencies]
rstest = { workspace = true }
vortex-array = { workspace = true, features = ["_test-harness"] }
vortex-btrblocks = { workspace = true }
vortex-mask = { workspace = true }
61 changes: 0 additions & 61 deletions vortex-tensor/src/encodings/l2_denorm.rs

This file was deleted.

Loading
Loading