OnPair: decode straight into the builder's byte storage - #9100
Draft
robert3005 wants to merge 1 commit into
Draft
Conversation
Same shape as the FSST change: `append_to_builder` staged the decoded heap in a temporary buffer before copying it in. `OnPairDecodePlan` hoists the code window, the dictionary view, the per-row lengths and the total decoded size out of `onpair_decode_bytes` so the decode can target the builder's spare capacity via `append_decoded`, leaving one prefix sum over the lengths as the only work beyond the bulk `try_decode_into`. `decode_into` is `#[inline(always)]`: `try_decode_into` is generic over the dictionary view and only specializes its batched copy loop once inlined into the caller, so leaving the wrapper out of line costs ~2.5x. Also extends the Arrow export benchmarks to cover OnPair alongside the other string encodings, plus nullable variants and the two `append_to_builder` benchmarks that reach an encoding's specialization directly — the Arrow export cannot stand in for those, since `execute_until` canonicalizes a bare FSST/OnPair/Zstd root before any builder sees it. Signed-off-by: Robert Kruszewski <robert@spiraldb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
What changes are included in this PR?
What APIs are changed? Are there any user-facing changes?