FSST: decompress straight into the builder's byte storage - #9097
Draft
robert3005 wants to merge 1 commit into
Draft
FSST: decompress straight into the builder's byte storage#9097robert3005 wants to merge 1 commit into
robert3005 wants to merge 1 commit into
Conversation
`append_to_builder` staged the decompressed heap in a temporary `ByteBufferMut` and then copied it into the builder. `FsstDecodePlan` hoists the parts of `fsst_decode_bytes` that describe the decode — the code stream, the per-row lengths and the total decoded size — so the decompression can target the builder's spare capacity directly via `append_decoded`, leaving one prefix sum over the lengths as the only work beyond the bulk `decompress_into`. `FSST_DECODE_SLACK` names the 7 spare bytes that keep `decompress_into` on its wide-store path through the final value; it is a performance knob, not a safety requirement. Signed-off-by: Robert Kruszewski <robert@spiraldb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
What changes are included in this PR?
What APIs are changed? Are there any user-facing changes?