perf(vortex-geo): short-circuit predicates with bounding boxes - #9076
Open
HarukiMoriarty wants to merge 2 commits into
Open
perf(vortex-geo): short-circuit predicates with bounding boxes#9076HarukiMoriarty wants to merge 2 commits into
HarukiMoriarty wants to merge 2 commits into
Conversation
Cache the constant geometry's bounding rectangle and use per-row rectangles to reject disjoint intersects and impossible contains checks before exact evaluation. Add correctness coverage and a comparative Divan microbenchmark. Signed-off-by: Nemo Yu <zyu379@wisc.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Constant-vs-column geometry predicates currently run the exact spatial predicate for every valid row, even when the constant and row bounding rectangles already prove that the result is false. For complex constant geometries and spatially selective queries, this repeats substantially more work than necessary.
What changes are included in this PR?
vortex.geo.intersectswhen operand rectangles are disjoint.vortex.geo.containswhen the container rectangle cannot cover the contained rectangle, preserving operand order.vortex.geo.distanceon exact evaluation because rectangles cannot determine the result.predicate_bboxDivan microbenchmark.Microbenchmark
Command:
The benchmark evaluates 16,384 points against a 128-vertex constant polygon. Median results:
contains, disjointcontains, candidateintersects, disjointintersects, candidate