Skip to content

duckdb: don't push down aggregation over floats - #9069

Merged
myrrc merged 1 commit into
developfrom
myrrc/duckdb-aggregate-float-pushdown
Jul 29, 2026
Merged

duckdb: don't push down aggregation over floats#9069
myrrc merged 1 commit into
developfrom
myrrc/duckdb-aggregate-float-pushdown

Conversation

@myrrc

@myrrc myrrc commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Duckdb's float NaN handling is substandard and conflicts with Vortex NaN
handling. To preserve output, disable float columns aggregate pushdown as
for now.

@myrrc myrrc added ext/duckdb Relates to the DuckDB integration changelog/fix A bug fix labels Jul 29, 2026
@myrrc
myrrc force-pushed the myrrc/duckdb-aggregate-float-pushdown branch from 73ed3b4 to ea18be8 Compare July 29, 2026 15:01
@myrrc
myrrc force-pushed the myrrc/duckdb-aggregate-float-pushdown branch from ea18be8 to 173cf1f Compare July 29, 2026 16:49
@myrrc
myrrc force-pushed the myrrc/duckdb-aggregate-float-pushdown branch from 173cf1f to e2c2fca Compare July 29, 2026 17:00
@myrrc
myrrc requested a review from AdamGS July 29, 2026 17:04
@myrrc
myrrc force-pushed the myrrc/duckdb-aggregate-float-pushdown branch from e2c2fca to 861f754 Compare July 29, 2026 17:18
@myrrc
myrrc changed the base branch from myrrc/zonemap-stats-aggregate-scan-splits to develop July 29, 2026 17:18
@myrrc
myrrc merged commit 2a54a2c into develop Jul 29, 2026
76 of 116 checks passed
@myrrc
myrrc deleted the myrrc/duckdb-aggregate-float-pushdown branch July 29, 2026 17:27
@myrrc
myrrc restored the myrrc/duckdb-aggregate-float-pushdown branch July 29, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix ext/duckdb Relates to the DuckDB integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants