Adjust strict docs - #9033
Merged
Merged
Conversation
connortsui20
force-pushed
the
ct/strict-docs-adjust
branch
3 times, most recently
from
July 29, 2026 15:31
1578a48 to
4e778a7
Compare
connortsui20
pushed a commit
that referenced
this pull request
Jul 30, 2026
#9033 reaches the strictness-is-not-totality conclusion independently and lands the documentation fix on develop, replacing the claimed validity equality with a one-sided bound and deleting the dense-evaluation consequence outright. Adopts that vocabulary here: is_total is now documented as the property that upgrades valid(f(a..)) subset-of AND valid(aj) to an equality, which is what makes the validity precomputable. The research doc records that #9033 supersedes the doc half of the two issues filed from this branch, so what remains of them is the API question and one regression test. Also refreshes the doc for the ports since: geo moved from the columnar layer to RowFn, list_sum joined the columnar layer, the constant-operand gap is closed, and the remaining element-vocabulary gap is a nullable output element. Signed-off-by: "Connor Sanders" <connor@spiraldb.com>
joseph-isaacs
disabled auto-merge
July 30, 2026 15:48
joseph-isaacs
approved these changes
Jul 30, 2026
Member
Author
|
Given that strict is a more well defined thing (postgres) and we can't think of any examples where something is null insensitive but not strict I feel like it makes more sense to stick with this definition |
Member
Author
|
Closes #9091 which I filed by accident |
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
force-pushed
the
ct/strict-docs-adjust
branch
from
July 30, 2026 16:43
4e778a7 to
55a1ce6
Compare
connortsui20
enabled auto-merge (squash)
July 30, 2026 16:43
connortsui20
pushed a commit
that referenced
this pull request
Jul 30, 2026
Records why there are two authoring traits and not one or three, which trait members are forced rather than chosen, the strictness-versus-totality finding and how it lines up with #9033, the problems worth extracting onto develop separately, and the known gaps the porting probes turned up. Signed-off-by: "Connor Sanders" <connor@spiraldb.com>
connortsui20
pushed a commit
that referenced
this pull request
Jul 30, 2026
Records why there are two authoring traits and not one or three, which trait members are forced rather than chosen, the strictness-versus-totality finding and how it lines up with #9033, the problems worth extracting onto develop separately, and the known gaps the porting probes turned up. Signed-off-by: "Connor Sanders" <connor@spiraldb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the semantics of strictness for the list scalar fns were unclear.