ci: add focused PR benchmark labels - #9018
Conversation
89eebfa to
77a7e5d
Compare
|
note that we probably dont want all of these labels, but I feel like a bit more than what we have on develop now would be nice? |
|
actually Im going to make them all disjoint, lets see how that works |
77a7e5d to
9cbc6da
Compare
2d3d02c to
c5173aa
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
|
Let's use bench-random-access, ra isn't straight obvious |
c5173aa to
0b4eb99
Compare
0b4eb99 to
dac3fb7
Compare
| # v4 (Postgres) ingest -- REQUIRED (see develop-bench.yml rationale). Empty records: | ||
| # post-ingest.py --postgres upserts the commit row only. Gated on the | ||
| # ingest-role ARN var (the assume-role input that MUST exist for OIDC to | ||
| # succeed). |
There was a problem hiding this comment.
Probably need a action/bench-gpu-compress label for GPU compress?
There was a problem hiding this comment.
yeah I am going to run this once this merges:
gh label edit "action/benchmark-gpu-compress" --name "action/bench-gpu-compress" \
--description "Run only the GPU compression benchmark on this PR"
gh label delete action/benchmark --yes
gh label delete action/benchmark-sql --yes
gh label delete action/benchmark-sql-full --yes
| "pr-compact": COMPACT, | ||
| "pr-full": FULL_PR, | ||
| "develop": FULL_LOCAL, | ||
| }, |
There was a problem hiding this comment.
is there any label reaching pr full?
There was a problem hiding this comment.
no since I think we should just keep everything disjoint, if someone wants to run more benchmarks I think they should just add all 4 (or 5 for gpu) labels.
4bbe37b to
fb5f8aa
Compare
| cat comment.md >> "$GITHUB_STEP_SUMMARY" | ||
| - name: Comment PR | ||
| if: github.event.pull_request.head.repo.fork == false | ||
| if: github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork == false |
There was a problem hiding this comment.
i think this is a qol change
fb5f8aa to
e332145
Compare
Benchmarks: TPC-H SF=10 on S3 📖Verdict: No clear signal (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-compact (1.022x ➖, 0↑ 1↓)
datafusion / parquet (1.052x ➖, 1↑ 1↓)
duckdb / vortex-compact (0.950x ➖, 0↑ 0↓)
duckdb / parquet (1.062x ➖, 0↑ 0↓)
|
Benchmarks: Statistical and Population Genetics 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
duckdb / vortex-compact (1.016x ➖, 0↑ 0↓)
duckdb / parquet (1.017x ➖, 0↑ 0↓)
No file size changes detected. |
Benchmarks: Clickbench on NVME 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-compact (1.060x ➖, 0↑ 12↓)
datafusion / parquet (0.971x ➖, 1↑ 0↓)
duckdb / vortex-compact (0.981x ➖, 2↑ 0↓)
duckdb / parquet (1.000x ➖, 0↑ 0↓)
No file size changes detected. |
Benchmarks: Appian on NVME 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-compact (1.076x ➖, 0↑ 2↓)
datafusion / parquet (1.050x ➖, 0↑ 1↓)
duckdb / vortex-compact (1.078x ➖, 0↑ 2↓)
duckdb / parquet (1.072x ➖, 0↑ 2↓)
No file size changes detected. |
|
There's a lot of file size changes here but I'm pretty sure there is something wrong currently on develop with that anyways? |
Benchmarks: Random Access 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
random-access / vortex-file-compressed (1.042x ➖, 0↑ 3↓)
random-access / parquet (1.050x ➖, 0↑ 3↓)
random-access / lance (1.014x ➖, 0↑ 0↓)
|
|
I forgot that by separating everything, I need to update the comment comparisons because they used to all be unified |
91df6c0 to
875a4b5
Compare
875a4b5 to
0cc5bf5
Compare
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
1247c00 to
b1b5ca5
Compare
Adds focused PR benchmark triggers:
action/bench-random-accessaction/bench-compressaction/bench-string(benchmarks: add string compression benchmark #9060)action/bench-sql(excludes Vortex Compact)action/bench-sql-compact(Vortex Compact plus Parquet controls)action/bench-all(random access, compression, string encoding, and SQL; GPU remains separate)Each trigger dispatches a role-specific reusable workflow. SQL coverage stays in the Python catalog and is resolved into a matrix at runtime. The all-CPU path uses a single
pr-allpreset (the exact union ofprandpr-compact), so shared SQL jobs run once instead of twice.Benchmark comparisons now:
TODO: After merge, delete the legacy
action/benchmark*labels oncedevelopuses the new dispatcher.