Use array_slots macro instead of manual slot indices - #8916
Conversation
36d4449 to
e24878c
Compare
Merging this PR will degrade performance by 14.44%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | copy_nullable[65536] |
578.8 µs | 1,033.3 µs | -43.98% |
| ❌ | Simulation | copy_non_nullable[65536] |
799 µs | 913.6 µs | -12.55% |
| ⚡ | Simulation | decode_varbin[(1000, 4)] |
34.3 µs | 26.8 µs | +27.83% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing myrrc/array-slots-macro (1c5cc67) with develop (3a098b4)
Footnotes
-
3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
e24878c to
d3c2409
Compare
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
d3c2409 to
1c5cc67
Compare
|
snap: #8912 |
|
Let's go with your PR |
Pull request was closed
Remove manual slot indices in favor of codegenerated ones