Skip to content

Use array_slots macro instead of manual slot indices - #8916

Closed
myrrc wants to merge 1 commit into
developfrom
myrrc/array-slots-macro
Closed

Use array_slots macro instead of manual slot indices#8916
myrrc wants to merge 1 commit into
developfrom
myrrc/array-slots-macro

Conversation

@myrrc

@myrrc myrrc commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Remove manual slot indices in favor of codegenerated ones

@myrrc myrrc added the changelog/skip Do not list PR in the changelog label Jul 23, 2026
@myrrc
myrrc enabled auto-merge (squash) July 23, 2026 13:29
@myrrc
myrrc requested a review from joseph-isaacs July 23, 2026 13:29
@myrrc
myrrc force-pushed the myrrc/array-slots-macro branch 3 times, most recently from 36d4449 to e24878c Compare July 23, 2026 13:45
@codspeed-hq

codspeed-hq Bot commented Jul 23, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 14.44%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 1 improved benchmark
❌ 2 regressed benchmarks
✅ 1887 untouched benchmarks
⏩ 3 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation copy_nullable[65536] 578.8 µs 1,033.3 µs -43.98%
Simulation copy_non_nullable[65536] 799 µs 913.6 µs -12.55%
Simulation decode_varbin[(1000, 4)] 34.3 µs 26.8 µs +27.83%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing myrrc/array-slots-macro (1c5cc67) with develop (3a098b4)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@myrrc
myrrc force-pushed the myrrc/array-slots-macro branch from e24878c to d3c2409 Compare July 23, 2026 14:22
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@myrrc
myrrc force-pushed the myrrc/array-slots-macro branch from d3c2409 to 1c5cc67 Compare July 23, 2026 14:33
@myrrc myrrc added changelog/feature A new feature and removed changelog/skip Do not list PR in the changelog labels Jul 23, 2026
@myrrc
myrrc requested a review from 0ax1 July 23, 2026 14:39
@joseph-isaacs

Copy link
Copy Markdown
Contributor

snap: #8912

@myrrc

myrrc commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Let's go with your PR

@myrrc myrrc closed this Jul 23, 2026
auto-merge was automatically disabled July 23, 2026 15:51

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants