break: new layout tree vtable - #8910
Merged
Merged
Conversation
joseph-isaacs
added
changelog/break
github-actions
Bot
removed
the
action/benchmark
Contributor
Polar Signals Profiling ResultsLatest Run
Previous Runs (5)
Powered by Polar Signals Cloud |
joseph-isaacs
added
the
do not merge
Contributor
Benchmarks: Vortex queries 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.117x ❌, 0↑ 1↓)
datafusion / parquet (1.076x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.093x ➖, 0↑ 0↓)
duckdb / parquet (1.032x ➖, 0↑ 0↓)
No file size changes detected. |
Contributor
Benchmarks: PolarSignals Profiling 📖Vortex (geomean): 1.006x ➖ How to read Verdict and Engines
datafusion / vortex-file-compressed (1.006x ➖, 0↑ 1↓)
No file size changes detected. |
Contributor
Benchmarks: TPC-H SF=1 on NVME 📖Verdict: No clear signal (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.003x ➖, 0↑ 0↓)
datafusion / vortex-compact (1.003x ➖, 0↑ 0↓)
datafusion / parquet (1.004x ➖, 1↑ 1↓)
datafusion / arrow (0.989x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.002x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.017x ➖, 0↑ 1↓)
duckdb / parquet (0.997x ➖, 1↑ 0↓)
duckdb / duckdb (1.007x ➖, 0↑ 0↓)
No file size changes detected. |
Contributor
Benchmarks: FineWeb NVMe 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.004x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.998x ➖, 1↑ 0↓)
datafusion / parquet (1.008x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.988x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.028x ➖, 0↑ 1↓)
duckdb / parquet (1.004x ➖, 0↑ 0↓)
No file size changes detected. |
Contributor
Benchmarks: TPC-DS SF=1 on NVME 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.926x ➖, 17↑ 0↓)
datafusion / vortex-compact (0.947x ➖, 5↑ 0↓)
datafusion / parquet (0.935x ➖, 15↑ 0↓)
duckdb / vortex-file-compressed (0.931x ➖, 22↑ 0↓)
duckdb / vortex-compact (0.954x ➖, 10↑ 0↓)
duckdb / parquet (0.950x ➖, 4↑ 0↓)
duckdb / duckdb (0.955x ➖, 8↑ 0↓)
No file size changes detected. |
joseph-isaacs
temporarily deployed
to
github-pages
July 23, 2026 10:05 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
Benchmarks: FineWeb S3 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.092x ➖, 0↑ 1↓)
datafusion / vortex-compact (0.954x ➖, 0↑ 0↓)
datafusion / parquet (0.940x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.959x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.925x ➖, 0↑ 0↓)
duckdb / parquet (0.940x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: Statistical and Population Genetics 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
duckdb / vortex-file-compressed (0.988x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.993x ➖, 0↑ 0↓)
duckdb / parquet (0.975x ➖, 0↑ 0↓)
No file size changes detected. |
Contributor
Benchmarks: Clickbench Sorted on NVME 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.221x ❌, 0↑ 9↓)
datafusion / parquet (1.209x ❌, 0↑ 10↓)
duckdb / vortex-file-compressed (1.184x ❌, 1↑ 8↓)
duckdb / parquet (1.128x ❌, 0↑ 9↓)
duckdb / duckdb (1.116x ❌, 0↑ 5↓)
File Size Changes (201 files changed, -0.1% overall, 92↑ 109↓)
Totals:
|
Contributor
Benchmarks: TPC-H SF=10 on NVME 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.989x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.989x ➖, 0↑ 0↓)
datafusion / parquet (0.995x ➖, 0↑ 0↓)
datafusion / arrow (0.995x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.004x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.997x ➖, 0↑ 0↓)
duckdb / parquet (1.002x ➖, 0↑ 0↓)
duckdb / duckdb (0.995x ➖, 0↑ 0↓)
No file size changes detected. |
Contributor
Benchmarks: Clickbench on NVME 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.990x ➖, 2↑ 2↓)
datafusion / parquet (0.985x ➖, 1↑ 1↓)
duckdb / vortex-file-compressed (1.026x ➖, 2↑ 5↓)
duckdb / parquet (1.006x ➖, 0↑ 0↓)
duckdb / duckdb (1.044x ➖, 0↑ 7↓)
File Size Changes (1 files changed, -0.0% overall, 0↑ 1↓)
Totals:
|
Contributor
Benchmarks: Random Access 📖Vortex (geomean): 1.077x ➖ How to read Verdict and Engines
unknown / unknown (1.054x ➖, 0↑ 10↓)
|
Contributor
Benchmarks: TPC-H SF=1 on S3 📖Verdict: No clear signal (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.970x ➖, 0↑ 0↓)
datafusion / vortex-compact (1.025x ➖, 0↑ 0↓)
datafusion / parquet (0.946x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.922x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.913x ➖, 0↑ 0↓)
duckdb / parquet (0.941x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: Appian on NVME 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.968x ➖, 0↑ 0↓)
datafusion / parquet (0.968x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.982x ➖, 0↑ 0↓)
duckdb / parquet (0.988x ➖, 0↑ 0↓)
duckdb / duckdb (0.981x ➖, 0↑ 0↓)
File Size Changes (1 files changed, -0.0% overall, 0↑ 1↓)
Totals:
|
Contributor
Benchmarks: TPC-H SF=10 on S3 📖Verdict: No clear signal (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.931x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.945x ➖, 0↑ 0↓)
datafusion / parquet (0.936x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.939x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.939x ➖, 0↑ 0↓)
duckdb / parquet (0.894x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: Compression 📖Vortex (geomean): 1.005x ➖ How to read Verdict and Engines
unknown / unknown (1.003x ➖, 0↑ 2↓)
|
Merging this PR will not alter performance
|
joseph-isaacs
temporarily deployed
to
github-pages
July 23, 2026 11:03 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> # Conflicts: # vortex-layout/src/layouts/zoned/mod.rs
joseph-isaacs
temporarily deployed
to
github-pages
July 23, 2026 13:32 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
joseph-isaacs
marked this pull request as ready for review
July 23, 2026 15:44
joseph-isaacs
added
action/benchmark
github-actions
Bot
removed
the
action/benchmark
robert3005
reviewed
Jul 23, 2026
robert3005
approved these changes
Jul 23, 2026
robert3005
left a comment
robert3005
left a comment
Contributor
There was a problem hiding this comment.
There's one small performance regression here
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> # Conflicts: # vortex-layout/src/layouts/zoned/mod.rs
joseph-isaacs
added
the
action/benchmark
github-actions
Bot
removed
the
action/benchmark
joseph-isaacs
added
the
action/benchmark
github-actions
Bot
removed
the
action/benchmark
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a API break, but NOT a wire break.
This PR moves the
VTableimplementation from the old VTable with a macro implementation to the new one closer toArrayRef.We have removed the
with_childrenmethod for now. I would expect that most usages of this where to change theLayoutReadernot the Layout directly.