FFI: get scalars from arrays - #8896
Open
myrrc wants to merge 2 commits into
Open
Conversation
myrrc
force-pushed
the
myrrc/ffi-getter-session
branch
from
July 22, 2026 12:32
3945f76 to
c305a0e
Compare
myrrc
force-pushed
the
myrrc/ffi-getter-session
branch
from
July 22, 2026 12:34
c305a0e to
b1ac575
Compare
Contributor
Polar Signals Profiling ResultsLatest Run
Previous Runs (1)
Powered by Polar Signals Cloud |
Contributor
|
Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.004x ➖, 0↑ 0↓)
datafusion / parquet (0.901x ➖, 1↑ 0↓)
duckdb / vortex-file-compressed (0.929x ➖, 0↑ 0↓)
duckdb / parquet (0.986x ➖, 0↑ 0↓)
No file size changes detected. |
myrrc
enabled auto-merge (squash)
July 22, 2026 12:36
0ax1
removed their request for review
July 23, 2026 13:47
myrrc
force-pushed
the
myrrc/ffi-getter-session
branch
from
July 28, 2026 14:13
b1ac575 to
ea86234
Compare
myrrc
force-pushed
the
myrrc/ffi-getter-session
branch
from
July 29, 2026 14:50
ea86234 to
255042c
Compare
myrrc
marked this pull request as draft
July 29, 2026 14:56
auto-merge was automatically disabled
July 29, 2026 14:56
Pull request was converted to draft
Contributor
Author
|
I've checked again, and I think we want a more gradual change. We do want to be able to get a scalar for an array, but we can't replace current getters with an intermediate vx_scalar:
I've removed the primitive accessors here. |
myrrc
force-pushed
the
myrrc/ffi-getter-session
branch
from
July 30, 2026 15:10
255042c to
49f87e7
Compare
myrrc
force-pushed
the
myrrc/ffi-getter-session
branch
2 times, most recently
from
July 30, 2026 15:43
36789e7 to
11f23f4
Compare
myrrc
marked this pull request as ready for review
July 30, 2026 15:55
myrrc
enabled auto-merge (squash)
July 30, 2026 15:55
myrrc
force-pushed
the
myrrc/ffi-getter-session
branch
from
July 30, 2026 15:58
11f23f4 to
413207b
Compare
myrrc
force-pushed
the
myrrc/ffi-getter-session
branch
from
July 30, 2026 16:03
413207b to
b0ff733
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error propagation in C bindings #7483