Skip to content

Revert "Lazily untranspose DeltaArray validity and depend on fastlanes bit transpose code" - #8883

Merged
robert3005 merged 1 commit into
developfrom
revert-8725-rk/transposedvalidity
Jul 21, 2026
Merged

Revert "Lazily untranspose DeltaArray validity and depend on fastlanes bit transpose code"#8883
robert3005 merged 1 commit into
developfrom
revert-8725-rk/transposedvalidity

Conversation

@joseph-isaacs

Copy link
Copy Markdown
Contributor

Reverts #8725

@robert3005 robert3005 added the changelog/fix A bug fix label Jul 21, 2026

@robert3005 robert3005 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Polar Signals Profiling Results

Latest Run

Status Commit Job Attempt Link
🟢 Done dde16d7 1 Explore Profiling Data

Powered by Polar Signals Cloud

@github-actions

Copy link
Copy Markdown
Contributor

Benchmarks: Vortex queries 📖

Verdict: No clear signal (low confidence)
Attributed Vortex impact: +5.3%
Engines: DataFusion No clear signal (+7.0%, low confidence) · DuckDB No clear signal (+3.7%, low confidence)
Vortex (geomean): 1.049x ➖
Parquet (geomean): 1.022x ➖
Shifts: Parquet (control) +2.2% · Median polish +4.6%

How to read Verdict and Engines
  • Verdict: Overall PR-level signal after subtracting baseline drift estimated from Parquet control rows. It can be Likely improvement, Likely regression, or No clear signal.
  • Engines: Per-engine attribution. DataFusion is compared against DataFusion/Parquet controls; DuckDB is compared against DuckDB/Parquet controls. This answers whether each engine improved or regressed independently.
  • Confidence: Based on directional consistency, share of rows above the noise floor, and control-run noise.

datafusion / vortex-file-compressed (1.087x ➖, 0↑ 0↓)
name PR dde16d7 (ns) base 1259557 (ns) ratio (PR/base)
vortex_q00/datafusion:vortex-file-compressed 10238206 9382395 1.09
vortex_q01/datafusion:vortex-file-compressed 6529500 6025257 1.08
datafusion / parquet (1.016x ➖, 0↑ 0↓)
name PR dde16d7 (ns) base 1259557 (ns) ratio (PR/base)
vortex_q00/datafusion:parquet 20772512 20028507 1.04
vortex_q01/datafusion:parquet 4759020 4779198 1.00
duckdb / vortex-file-compressed (1.065x ➖, 0↑ 0↓)
name PR dde16d7 (ns) base 1259557 (ns) ratio (PR/base)
vortex_q00/duckdb:vortex-file-compressed 10621558 9829718 1.08
vortex_q01/duckdb:vortex-file-compressed 6203834 5909368 1.05
duckdb / parquet (1.028x ➖, 0↑ 0↓)
name PR dde16d7 (ns) base 1259557 (ns) ratio (PR/base)
vortex_q00/duckdb:parquet 23797942 23302296 1.02
vortex_q01/duckdb:parquet 9703044 9385906 1.03

No file size changes detected.

@robert3005
robert3005 enabled auto-merge (squash) July 21, 2026 16:41
@robert3005
robert3005 merged commit b7ee873 into develop Jul 21, 2026
110 of 113 checks passed
@robert3005
robert3005 deleted the revert-8725-rk/transposedvalidity branch July 21, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants