Skip to content

Remove mutable state from Vortex open options - #8879

Merged
onursatici merged 2 commits into
developfrom
os/open-options
Jul 21, 2026
Merged

Remove mutable state from Vortex open options#8879
onursatici merged 2 commits into
developfrom
os/open-options

Conversation

@onursatici

Copy link
Copy Markdown
Contributor

Rationale for this change

Vortex open options shouldn't have mutable state, so return the mutable state separately

Signed-off-by: Onur Satici <onur@spiraldb.com>
Signed-off-by: Onur Satici <onur@spiraldb.com>
@onursatici onursatici added the changelog/chore A trivial change label Jul 21, 2026
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Polar Signals Profiling Results

Latest Run

Status Commit Job Attempt Link
🟢 Done c0086e5 1 Explore Profiling Data

Powered by Polar Signals Cloud

@github-actions

Copy link
Copy Markdown
Contributor

Benchmarks: Vortex queries 📖

Verdict: No clear signal (low confidence)
Attributed Vortex impact: -3.5%
Engines: DataFusion No clear signal (+5.8%, low confidence) · DuckDB Likely improvement (-11.9%, high confidence)
Vortex (geomean): 0.871x ✅
Parquet (geomean): 0.887x ✅
Shifts: Parquet (control) -11.3% · Median polish -14.4%

How to read Verdict and Engines
  • Verdict: Overall PR-level signal after subtracting baseline drift estimated from Parquet control rows. It can be Likely improvement, Likely regression, or No clear signal.
  • Engines: Per-engine attribution. DataFusion is compared against DataFusion/Parquet controls; DuckDB is compared against DuckDB/Parquet controls. This answers whether each engine improved or regressed independently.
  • Confidence: Based on directional consistency, share of rows above the noise floor, and control-run noise.

datafusion / vortex-file-compressed (0.876x ✅, 2↑ 0↓)
name PR c0086e5 (ns) base ba4acb6 (ns) ratio (PR/base)
vortex_q00/datafusion:vortex-file-compressed 🚀 9636645 10798352 0.89
vortex_q01/datafusion:vortex-file-compressed 🚀 6234471 7243681 0.86
datafusion / parquet (0.828x ✅, 2↑ 0↓)
name PR c0086e5 (ns) base ba4acb6 (ns) ratio (PR/base)
vortex_q00/datafusion:parquet 🚀 19753295 23278380 0.85
vortex_q01/datafusion:parquet 🚀 4606822 5695818 0.81
duckdb / vortex-file-compressed (0.837x ✅, 2↑ 0↓)
name PR c0086e5 (ns) base ba4acb6 (ns) ratio (PR/base)
vortex_q00/duckdb:vortex-file-compressed 🚀 10041909 11992591 0.84
vortex_q01/duckdb:vortex-file-compressed 🚀 5940001 7107676 0.84
duckdb / parquet (0.950x ➖, 0↑ 0↓)
name PR c0086e5 (ns) base ba4acb6 (ns) ratio (PR/base)
vortex_q00/duckdb:parquet 23492335 24784372 0.95
vortex_q01/duckdb:parquet 9469790 9953358 0.95

No file size changes detected.

@onursatici
onursatici enabled auto-merge (squash) July 21, 2026 13:16
@onursatici
onursatici merged commit c42934b into develop Jul 21, 2026
83 of 84 checks passed
@onursatici
onursatici deleted the os/open-options branch July 21, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants