Share fixed-width structural array operations - #8864
Draft
connortsui20 wants to merge 6 commits into
Draft
Conversation
Merging this PR will degrade performance by 10.1%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
connortsui20
force-pushed
the
ct/fixed-width-primitive-decimal
branch
2 times, most recently
from
July 20, 2026 19:50
76fd71a to
f00395e
Compare
connortsui20
commented
Jul 20, 2026
robert3005
reviewed
Jul 20, 2026
connortsui20
force-pushed
the
ct/fixed-width-primitive-decimal
branch
2 times, most recently
from
July 20, 2026 22:05
35a4157 to
2e0b1e2
Compare
connortsui20
force-pushed
the
ct/fixed-width-primitive-decimal
branch
2 times, most recently
from
July 20, 2026 22:33
35a4157 to
2880b5f
Compare
connortsui20
force-pushed
the
ct/fixed-width-primitive-decimal
branch
from
July 20, 2026 22:42
2880b5f to
f124538
Compare
connortsui20
added a commit
that referenced
this pull request
Jul 21, 2026
## Summary - remove the unused `ArrayRef::is_arrow` helper - keep this reviewer-requested cleanup separate from #8864 ## Testing - `cargo check -p vortex-array` - `cargo clippy --all-targets --all-features` (pre-push hook) Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
force-pushed
the
ct/fixed-width-primitive-decimal
branch
4 times, most recently
from
July 22, 2026 19:29
6768bec to
19c65ac
Compare
connortsui20
force-pushed
the
ct/fixed-width-primitive-decimal
branch
2 times, most recently
from
July 23, 2026 19:15
a4e7a55 to
853eb8f
Compare
connortsui20
force-pushed
the
ct/fixed-width-primitive-decimal
branch
3 times, most recently
from
July 27, 2026 18:25
2d5d094 to
3eb9698
Compare
connortsui20
force-pushed
the
ct/fixed-width-primitive-decimal
branch
from
July 28, 2026 15:30
3eb9698 to
74f9105
Compare
connortsui20
force-pushed
the
ct/fixed-width-primitive-decimal
branch
from
July 28, 2026 16:47
1bcf52b to
40e3fe6
Compare
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Address review feedback on the shared fixed-width kernels: - Document the contract of every FixedWidthArray hook. - Validate the records buffer length once in a shared with_values helper instead of in each implementation, which are now pure constructors. - Share the byte-width dispatch between take and filter through a single match_each_record_width macro. - Fix the miri gate on the AVX2 tests, which was previously a no-op module-level ignore attribute. - Test the arbitrary-width fallback paths of both take and filter, and restore 2-byte and float filter conformance coverage. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
force-pushed
the
ct/fixed-width-primitive-decimal
branch
from
July 30, 2026 19:09
40e3fe6 to
dfc6a40
Compare
Contributor
|
I thought there would be more lines removed, i.e. majority of Primitive and Decimal array should be gone? |
Member
Author
|
The majority is gone, the reason there's extra code is all the boilerplate and extra files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Primitive and Decimal are different logical types, but their structural operations both move fixed-width records from one values buffer and propagate validity. Keeping separate take/filter pipelines meant fixes and optimizations still had to be maintained twice.
What
FixedWidthArrayadapter for byte width, values access, and reconstructionReview structure
Issue provenance
index == lenand silently zeroed some larger invalid indices.