Skip to content

LayoutEncodingAdapter::build doesn't need to panic, it can error - #8824

Merged
robert3005 merged 1 commit into
developfrom
rk/layoutbuildpanic
Jul 17, 2026
Merged

LayoutEncodingAdapter::build doesn't need to panic, it can error#8824
robert3005 merged 1 commit into
developfrom
rk/layoutbuildpanic

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

Those panics look like an omission

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 added the changelog/fix A bug fix label Jul 17, 2026
@robert3005
robert3005 enabled auto-merge (squash) July 17, 2026 14:11
@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Polar Signals Profiling Results

Latest Run

Status Commit Job Attempt Link
🟢 Done ca696bd 1 Explore Profiling Data

Powered by Polar Signals Cloud

@github-actions

Copy link
Copy Markdown
Contributor

Benchmarks: Vortex queries

Verdict: Likely regression (high confidence)
Attributed Vortex impact: +14.7%
Engines: DataFusion Likely regression (+14.1%, high confidence) · DuckDB Likely regression (+15.2%, high confidence)
Vortex (geomean): 1.177x ❌
Parquet (geomean): 1.099x ➖
Shifts: Parquet (control) +9.9% · Median polish +17.9%

How to read Verdict and Engines
  • Verdict: Overall PR-level signal after subtracting baseline drift estimated from Parquet control rows. It can be Likely improvement, Likely regression, or No clear signal.
  • Engines: Per-engine attribution. DataFusion is compared against DataFusion/Parquet controls; DuckDB is compared against DuckDB/Parquet controls. This answers whether each engine improved or regressed independently.
  • Confidence: Based on directional consistency, share of rows above the noise floor, and control-run noise.

datafusion / vortex-file-compressed (1.264x ❌, 0↑ 2↓)
name PR ca696bd (ns) base 10b8173 (ns) ratio (PR/base)
vortex_q00/datafusion:vortex-file-compressed 🚨 11980697 9517908 1.26
vortex_q01/datafusion:vortex-file-compressed 🚨 7582449 5978341 1.27
datafusion / parquet (1.107x ❌, 0↑ 1↓)
name PR ca696bd (ns) base 10b8173 (ns) ratio (PR/base)
vortex_q00/datafusion:parquet 22519524 20503552 1.10
vortex_q01/datafusion:parquet 🚨 5218480 4674824 1.12
duckdb / vortex-file-compressed (1.256x ❌, 0↑ 2↓)
name PR ca696bd (ns) base 10b8173 (ns) ratio (PR/base)
vortex_q00/duckdb:vortex-file-compressed 🚨 12287265 9942582 1.24
vortex_q01/duckdb:vortex-file-compressed 🚨 7487620 5865264 1.28
duckdb / parquet (1.090x ➖, 0↑ 1↓)
name PR ca696bd (ns) base 10b8173 (ns) ratio (PR/base)
vortex_q00/duckdb:parquet 🚨 25824564 23082716 1.12
vortex_q01/duckdb:parquet 9941066 9356142 1.06

No file size changes detected.

@robert3005
robert3005 merged commit 928738e into develop Jul 17, 2026
81 of 82 checks passed
@robert3005
robert3005 deleted the rk/layoutbuildpanic branch July 17, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants