Expose CUDA-compatible file sink through FFI - #8784
Conversation
Benchmarks: Vortex queriesVerdict: Likely regression (high confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.225x ❌, 0↑ 2↓)
datafusion / parquet (1.136x ❌, 0↑ 2↓)
duckdb / vortex-file-compressed (1.247x ❌, 0↑ 2↓)
duckdb / parquet (1.065x ➖, 0↑ 0↓)
No file size changes detected. |
myrrc
left a comment
There was a problem hiding this comment.
LGTM for vortex-ffi changes
Signed-off-by: Onur Satici <onur@spiraldb.com>
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
Merging this PR will degrade performance by 13.22%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | WallTime | cuda/bitpacked_u8/unpack/3bw[100M] |
301.6 µs | 347.5 µs | -13.22% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing os/ffi-cuda (9a15dd8) with develop (1c419e5)
Footnotes
-
9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Rationale for this change
cuda compatible vortex files currently can't be written over ffi
What changes are included in this PR?
ffi to allow writing with the cuda compatible strategy, which only includes encodings that we have gpu kernels for, and also uses the cuda flat layout that uses the array tree from the footer. Also exclude alp-rd and pco from the cuda compatible encoding allowlist for completeness