Skip to content

Separate and merge .h/.hpp files in duckdb - #8566

Merged
myrrc merged 1 commit into
developfrom
myrrc/duckdb-less-code
Jun 24, 2026
Merged

Separate and merge .h/.hpp files in duckdb#8566
myrrc merged 1 commit into
developfrom
myrrc/duckdb-less-code

Conversation

@myrrc

@myrrc myrrc commented Jun 24, 2026

Copy link
Copy Markdown
Contributor
  • Merge small .h files into vortex_duckdb.h
  • Separate C++ code not used in bindgen to .hpp files
  • Remove dead code from duckdb: duckdb_vector_to_string, Config,
    ClientContext, duckdb_vx_add_extension_option, DDBString creation.
  • Remove rest duckdbfs code. Duckdbfs was partially removed in Remove duckdbfs #8468 but the Rust-side code survived.

@myrrc myrrc added the changelog/skip Do not list PR in the changelog label Jun 24, 2026
@codspeed-hq

codspeed-hq Bot commented Jun 24, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 4 improved benchmarks
❌ 2 regressed benchmarks
✅ 1583 untouched benchmarks
⏩ 4 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_varbinview_into_canonical[(1000, 10)] 168.8 µs 205.6 µs -17.86%
Simulation slice_empty_vortex 310 ns 368.3 ns -15.84%
Simulation bitwise_not_vortex_buffer_mut[128] 273.6 ns 215.3 ns +27.1%
Simulation chunked_varbinview_opt_canonical_into[(1000, 10)] 205.9 µs 169.4 µs +21.54%
Simulation bitwise_not_vortex_buffer_mut[1024] 333.9 ns 275.6 ns +21.17%
Simulation bitwise_not_vortex_buffer_mut[2048] 427.8 ns 369.4 ns +15.79%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing myrrc/duckdb-less-code (fb66c73) with develop (0726fb9)

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@myrrc
myrrc force-pushed the myrrc/duckdb-less-code branch from 93dcec6 to 9eeb2e4 Compare June 24, 2026 10:44
@myrrc
myrrc requested a review from 0ax1 June 24, 2026 10:45
@myrrc
myrrc force-pushed the myrrc/duckdb-less-code branch from 9eeb2e4 to 38ce388 Compare June 24, 2026 10:46
@myrrc
myrrc marked this pull request as ready for review June 24, 2026 10:49
@myrrc
myrrc requested a review from a team June 24, 2026 10:49
@myrrc myrrc added the ext/duckdb Relates to the DuckDB integration label Jun 24, 2026
@myrrc
myrrc enabled auto-merge (squash) June 24, 2026 10:56
@myrrc
myrrc requested a review from gatesn June 24, 2026 11:07
Comment thread vortex-duckdb/cpp/vector.cpp Outdated
Comment thread vortex-duckdb/cpp/vector.cpp
Comment thread vortex-duckdb/src/lib.rs
@0ax1
0ax1 disabled auto-merge June 24, 2026 13:28
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@myrrc
myrrc force-pushed the myrrc/duckdb-less-code branch from 38ce388 to fb66c73 Compare June 24, 2026 13:38
@myrrc
myrrc merged commit b0fb9f1 into develop Jun 24, 2026
69 checks passed
@myrrc
myrrc deleted the myrrc/duckdb-less-code branch June 24, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/skip Do not list PR in the changelog ext/duckdb Relates to the DuckDB integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants