Skip to content

assert_arrays_eq and assert_nth_scalar require ExecutionCtx - #8509

Merged
robert3005 merged 12 commits into
developfrom
assert_arrays_eq
Jun 22, 2026
Merged

assert_arrays_eq and assert_nth_scalar require ExecutionCtx#8509
robert3005 merged 12 commits into
developfrom
assert_arrays_eq

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

Part of migration to populate execution context everywhere

@robert3005
robert3005 requested a review from a team June 19, 2026 14:44
@robert3005 robert3005 added the changelog/chore A trivial change label Jun 19, 2026
@codspeed-hq

codspeed-hq Bot commented Jun 19, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 14.12%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 6 improved benchmarks
❌ 2 regressed benchmarks
✅ 1575 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_varbinview_into_canonical[(1000, 10)] 169 µs 205.6 µs -17.82%
Simulation slice_empty_vortex 310 ns 368.3 ns -15.84%
Simulation chunked_bool_canonical_into[(1000, 10)] 27 µs 16.2 µs +66.84%
Simulation bitwise_not_vortex_buffer_mut[128] 244.4 ns 186.1 ns +31.34%
Simulation bitwise_not_vortex_buffer_mut[1024] 304.7 ns 246.4 ns +23.68%
Simulation bitwise_not_vortex_buffer_mut[2048] 398.6 ns 340.3 ns +17.14%
Simulation chunked_varbinview_canonical_into[(100, 100)] 259 µs 223.8 µs +15.7%
Simulation chunked_varbinview_into_canonical[(100, 100)] 306.5 µs 270.8 µs +13.19%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing assert_arrays_eq (18cfdab) with develop (f1adef2)

Open in CodSpeed

@robert3005
robert3005 enabled auto-merge (squash) June 22, 2026 15:08
@robert3005
robert3005 disabled auto-merge June 22, 2026 15:27
Comment thread encodings/parquet-variant/src/compute/allnondistinct.rs Outdated
robert3005 and others added 9 commits June 22, 2026 18:42
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
…s_eq

assert_arrays_eq now uses find_mismatched_indices (scalar comparison) for
detection again; the AllNonDistinct-based comparison and its variant-type
implementation are extracted to a separate (stacked) PR.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Robert Kruszewski <github@robertk.io>
The new ext_storage compute function's tests used the pre-ctx 2-arg
assert_arrays_eq!; thread a ctx via array_execution_ctx() to match the
ExecutionCtx-requiring macro on this branch.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005
robert3005 enabled auto-merge (squash) June 22, 2026 23:08
@robert3005
robert3005 disabled auto-merge June 22, 2026 23:08
@robert3005
robert3005 enabled auto-merge (squash) June 22, 2026 23:08
@robert3005
robert3005 merged commit 5a764e6 into develop Jun 22, 2026
90 of 95 checks passed
@robert3005
robert3005 deleted the assert_arrays_eq branch June 22, 2026 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants