assert_arrays_eq and assert_nth_scalar require ExecutionCtx - #8509
Merged
Conversation
robert3005
force-pushed
the
assert_arrays_eq
branch
from
June 19, 2026 15:13
a15f1c9 to
555c5b8
Compare
Merging this PR will improve performance by 14.12%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | chunked_varbinview_into_canonical[(1000, 10)] |
169 µs | 205.6 µs | -17.82% |
| ❌ | Simulation | slice_empty_vortex |
310 ns | 368.3 ns | -15.84% |
| ⚡ | Simulation | chunked_bool_canonical_into[(1000, 10)] |
27 µs | 16.2 µs | +66.84% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[128] |
244.4 ns | 186.1 ns | +31.34% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[1024] |
304.7 ns | 246.4 ns | +23.68% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[2048] |
398.6 ns | 340.3 ns | +17.14% |
| ⚡ | Simulation | chunked_varbinview_canonical_into[(100, 100)] |
259 µs | 223.8 µs | +15.7% |
| ⚡ | Simulation | chunked_varbinview_into_canonical[(100, 100)] |
306.5 µs | 270.8 µs | +13.19% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing assert_arrays_eq (18cfdab) with develop (f1adef2)
robert3005
force-pushed
the
assert_arrays_eq
branch
from
June 22, 2026 11:29
02dff9a to
b522202
Compare
robert3005
enabled auto-merge (squash)
June 22, 2026 15:08
robert3005
disabled auto-merge
June 22, 2026 15:27
onursatici
reviewed
Jun 22, 2026
robert3005
force-pushed
the
assert_arrays_eq
branch
from
June 22, 2026 16:21
d2e21c2 to
26c7902
Compare
onursatici
approved these changes
Jun 22, 2026
Signed-off-by: Robert Kruszewski <github@robertk.io>
…s_eq assert_arrays_eq now uses find_mismatched_indices (scalar comparison) for detection again; the AllNonDistinct-based comparison and its variant-type implementation are extracted to a separate (stacked) PR. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Robert Kruszewski <github@robertk.io>
The new ext_storage compute function's tests used the pre-ctx 2-arg assert_arrays_eq!; thread a ctx via array_execution_ctx() to match the ExecutionCtx-requiring macro on this branch. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Robert Kruszewski <github@robertk.io>
robert3005
force-pushed
the
assert_arrays_eq
branch
from
June 22, 2026 17:42
29f944e to
8c78821
Compare
robert3005
enabled auto-merge (squash)
June 22, 2026 23:08
robert3005
disabled auto-merge
June 22, 2026 23:08
robert3005
enabled auto-merge (squash)
June 22, 2026 23:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of migration to populate execution context everywhere