Change ALIGNMENT_TO_HOST_COPY to Alignment::HOST_COPY - #8488
Conversation
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Merging this PR will not alter performance
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | chunked_varbinview_canonical_into[(1000, 10)] |
161.8 µs | 198.6 µs | -18.54% |
| ❌ | Simulation | chunked_varbinview_into_canonical[(1000, 10)] |
178 µs | 214.7 µs | -17.11% |
| ❌ | Simulation | chunked_varbinview_canonical_into[(100, 100)] |
273.7 µs | 308.4 µs | -11.25% |
| ⚡ | Simulation | take_10k_random |
255.7 µs | 197.8 µs | +29.23% |
| ⚡ | Simulation | take_10k_contiguous |
276.2 µs | 218.3 µs | +26.54% |
| ⚡ | Simulation | patched_take_10k_contiguous_patches |
290.9 µs | 232.3 µs | +25.21% |
| ⚡ | Simulation | patched_take_10k_random |
302.9 µs | 244.2 µs | +24.01% |
| ⚡ | Simulation | chunked_varbinview_opt_canonical_into[(1000, 10)] |
214.3 µs | 177.8 µs | +20.54% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[128] |
244.4 ns | 215.3 ns | +13.55% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[1024] |
304.7 ns | 275.6 ns | +10.58% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing adamg/alignment-minor-change (39a9213) with develop (ad46b6c)2
Footnotes
-
3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
develop(59cf59c) during the generation of this report, so ad46b6c was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
Summary
Just a minor API change. I think this is much nicer and removes an import at the callsite.
API Changes
Removes the
ALIGNMENT_TO_HOST_COPYconst in favor ofAlignment::HOST_COPY.