Skip to content

Minimize alignment noise in bitbuffer benchmarks #8487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AdamGS wants to merge 1 commit into from
Closed

Minimize alignment noise in bitbuffer benchmarks #8487

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 53 additions & 17 deletions vortex-buffer/benches/vortex_bitbuffer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,11 @@ use std::iter::Iterator;
use arrow_buffer::BooleanBuffer;
use arrow_buffer::BooleanBufferBuilder;
use divan::Bencher;
use vortex_buffer::Alignment;
use vortex_buffer::BitBuffer;
use vortex_buffer::BitBufferMut;
use vortex_buffer::BufferMut;
use vortex_buffer::collect_bool_words;

fn main() {
// Pre-warm CPUID feature detection so the one-time probe cost is never
Expand All @@ -32,12 +35,45 @@ impl FromIterator<bool> for Arrow<BooleanBuffer> {
}

const INPUT_SIZE: &[usize] = &[128, 1024, 2048, 16_384, 65_536];
// CodSpeed's Divan adapter measures one generated input per benchmark URI, so keep
// allocator alignment out of run-to-run comparisons.
const BENCH_ALIGNMENT: Alignment = Alignment::new(128);

#[inline]
fn true_count_pattern(i: usize) -> bool {
(i.is_multiple_of(3)) ^ (i.is_multiple_of(11))
}

fn bit_buffer_with_capacity(capacity: usize) -> BitBufferMut {
BitBufferMut::from_buffer(
BufferMut::with_capacity_aligned(capacity.div_ceil(8), BENCH_ALIGNMENT),
0,
0,
)
}

fn bit_buffer_mut_from_fn<F>(len: usize, f: F) -> BitBufferMut
where
F: FnMut(usize) -> bool,
{
let num_words = len.div_ceil(64);
let mut buffer = BufferMut::<u64>::with_capacity_aligned(num_words, BENCH_ALIGNMENT);
// SAFETY: `collect_bool_words` writes every word before any read.
unsafe { buffer.set_len(num_words) };
collect_bool_words(buffer.as_mut_slice(), len, f);

let mut bytes = buffer.into_byte_buffer();
bytes.truncate(len.div_ceil(8));
BitBufferMut::from_buffer(bytes, 0, len)
}
Comment thread
robert3005 marked this conversation as resolved.

fn bit_buffer_from_fn<F>(len: usize, f: F) -> BitBuffer
where
F: FnMut(usize) -> bool,
{
bit_buffer_mut_from_fn(len, f).freeze()
}

#[cfg(not(codspeed))]
#[divan::bench(args = INPUT_SIZE)]
fn from_iter_arrow(n: usize) {
Expand All @@ -52,7 +88,7 @@ fn from_iter_bit_buffer(n: usize) {
#[divan::bench(args = INPUT_SIZE)]
fn append_vortex_buffer(bencher: Bencher, length: usize) {
bencher
.with_inputs(|| (BitBufferMut::with_capacity(length), length))
.with_inputs(|| (bit_buffer_with_capacity(length), length))
.bench_refs(|(buffer, length)| {
for idx in 0..*length {
buffer.append(idx % 2 == 0);
Expand All @@ -74,7 +110,7 @@ fn append_arrow_buffer(bencher: Bencher, length: usize) {
#[divan::bench(args = INPUT_SIZE)]
fn append_n_vortex_buffer(bencher: Bencher, length: usize) {
bencher
.with_inputs(|| (BitBufferMut::with_capacity(length), length, true))
.with_inputs(|| (bit_buffer_with_capacity(length), length, true))
.bench_refs(|(buffer, length, boolean)| {
for _ in 0..100 {
buffer.append_n(*boolean, *length / 100);
Expand All @@ -97,8 +133,8 @@ fn append_n_arrow_buffer(bencher: Bencher, length: usize) {
fn append_buffer_vortex_buffer(bencher: Bencher, length: usize) {
bencher
.with_inputs(|| {
let source = BitBuffer::from_iter((0..length / 100).map(|i| i % 2 == 0));
let dest = BitBufferMut::with_capacity(length);
let source = bit_buffer_from_fn(length / 100, |i| i % 2 == 0);
let dest = bit_buffer_with_capacity(length);
(source, dest)
})
.bench_refs(|(source, dest)| {
Expand Down Expand Up @@ -129,7 +165,7 @@ fn append_buffer_arrow_buffer(bencher: Bencher, length: usize) {

#[divan::bench(args = INPUT_SIZE)]
fn value_vortex_buffer(bencher: Bencher, length: usize) {
let buffer = BitBuffer::from_iter((0..length).map(|i| i % 2 == 0));
let buffer = bit_buffer_from_fn(length, |i| i % 2 == 0);
bencher.with_inputs(|| &buffer).bench_refs(|buffer| {
for idx in 0..length {
divan::black_box(buffer.value(idx));
Expand All @@ -149,7 +185,7 @@ fn value_arrow_buffer(bencher: Bencher, length: usize) {

#[divan::bench(args = INPUT_SIZE)]
fn slice_vortex_buffer(bencher: Bencher, length: usize) {
let buffer = BitBuffer::from_iter((0..length).map(|i| i % 2 == 0));
let buffer = bit_buffer_from_fn(length, |i| i % 2 == 0);
bencher
.with_inputs(|| (&buffer, length / 2))
.bench_refs(|(buffer, mid)| {
Expand All @@ -172,7 +208,7 @@ fn slice_arrow_buffer(bencher: Bencher, length: usize) {

#[divan::bench(args = INPUT_SIZE)]
fn true_count_vortex_buffer(bencher: Bencher, length: usize) {
let buffer = BitBuffer::from_iter((0..length).map(true_count_pattern));
let buffer = bit_buffer_from_fn(length, true_count_pattern);

bencher
.with_inputs(|| &buffer)
Expand All @@ -194,8 +230,8 @@ fn true_count_arrow_buffer(bencher: Bencher, length: usize) {

#[divan::bench(args = INPUT_SIZE)]
fn bitwise_and_vortex_buffer(bencher: Bencher, length: usize) {
let a = BitBuffer::from_iter((0..length).map(|i| i % 2 == 0));
let b = BitBuffer::from_iter((0..length).map(|i| i % 3 == 0));
let a = bit_buffer_from_fn(length, |i| i % 2 == 0);
let b = bit_buffer_from_fn(length, |i| i % 3 == 0);
bencher
.with_inputs(|| (&a, &b))
.bench_values(|(a, b)| a & b);
Expand All @@ -215,16 +251,16 @@ fn bitwise_and_arrow_buffer(bencher: Bencher, length: usize) {
/// `bitwise_and_vortex_buffer` (reference-LHS, which always allocates a result buffer).
#[divan::bench(args = INPUT_SIZE)]
fn bitand_owned_lhs_vortex_buffer(bencher: Bencher, length: usize) {
let b = BitBuffer::from_iter((0..length).map(|i| i % 3 == 0));
let b = bit_buffer_from_fn(length, |i| i % 3 == 0);
bencher
.with_inputs(|| BitBuffer::from_iter((0..length).map(|i| i % 2 == 0)))
.with_inputs(|| bit_buffer_from_fn(length, |i| i % 2 == 0))
.bench_values(|a| a & &b);
}

#[divan::bench(args = INPUT_SIZE)]
fn bitwise_or_vortex_buffer(bencher: Bencher, length: usize) {
let a = BitBuffer::from_iter((0..length).map(|i| i % 2 == 0));
let b = BitBuffer::from_iter((0..length).map(|i| i % 3 == 0));
let a = bit_buffer_from_fn(length, |i| i % 2 == 0);
let b = bit_buffer_from_fn(length, |i| i % 3 == 0);
bencher
.with_inputs(|| (&a, &b))
.bench_values(|(a, b)| a | b);
Expand All @@ -242,14 +278,14 @@ fn bitwise_or_arrow_buffer(bencher: Bencher, length: usize) {
#[divan::bench(args = INPUT_SIZE)]
fn bitwise_not_vortex_buffer(bencher: Bencher, length: usize) {
bencher
.with_inputs(|| BitBuffer::from_iter((0..length).map(|i| i % 2 == 0)))
.with_inputs(|| bit_buffer_from_fn(length, |i| i % 2 == 0))
.bench_values(|buffer| !&buffer);
}

#[divan::bench(args = INPUT_SIZE)]
fn bitwise_not_vortex_buffer_mut(bencher: Bencher, length: usize) {
bencher
.with_inputs(|| BitBufferMut::from_iter((0..length).map(|i| i % 2 == 0)))
.with_inputs(|| bit_buffer_mut_from_fn(length, |i| i % 2 == 0))
.bench_values(|buffer| !buffer);
}

Expand All @@ -262,7 +298,7 @@ fn bitwise_not_arrow_buffer(bencher: Bencher, length: usize) {

#[divan::bench(args = INPUT_SIZE)]
fn iter_vortex_buffer(bencher: Bencher, length: usize) {
let buffer = BitBuffer::from_iter((0..length).map(|i| i % 2 == 0));
let buffer = bit_buffer_from_fn(length, |i| i % 2 == 0);
bencher.with_inputs(|| &buffer).bench_refs(|buffer| {
for value in buffer.iter() {
divan::black_box(value);
Expand All @@ -282,7 +318,7 @@ fn iter_arrow_buffer(bencher: Bencher, length: usize) {

#[divan::bench(args = INPUT_SIZE)]
fn set_indices_vortex_buffer(bencher: Bencher, length: usize) {
let buffer = BitBuffer::from_iter((0..length).map(|i| i % 2 == 0));
let buffer = bit_buffer_from_fn(length, |i| i % 2 == 0);
bencher.with_inputs(|| &buffer).bench_refs(|buffer| {
for idx in buffer.set_indices() {
divan::black_box(idx);
Expand Down
Loading