perf: don't use fill_null for executing an array into a mask - #8466
Performance Regression: -1.38%
⚠️ Unknown Walltime execution environment detected
Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.
For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.
⚡ 2 improved benchmarks
❌ 3 regressed benchmarks
✅ 1576 untouched benchmarks
⏩ 3 skipped benchmarks1
Warning
Please fix the performance issues or acknowledge them on CodSpeed.
Performance Changes
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | chunked_varbinview_canonical_into[(1000, 10)] |
162.2 µs | 198.2 µs | -18.16% |
| ❌ | Simulation | chunked_varbinview_canonical_into[(100, 100)] |
273.2 µs | 308.6 µs | -11.49% |
| ❌ | Simulation | chunked_varbinview_into_canonical[(100, 100)] |
330.8 µs | 367.7 µs | -10.04% |
| ⚡ | Simulation | chunked_varbinview_opt_canonical_into[(1000, 10)] |
213.8 µs | 176.9 µs | +20.86% |
| ⚡ | Simulation | chunked_varbinview_opt_into_canonical[(1000, 10)] |
229.1 µs | 193.4 µs | +18.46% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing ji/fix-mask-fill-null-regression (b3c69d8) with develop (a4476f1)
Footnotes
-
3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩