Skip to content

ci: use ctest #8439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joseph-isaacs wants to merge 1 commit into from
Closed

ci: use ctest #8439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/rust-instrumented.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,8 @@ jobs:
- name: Run tests
run: |
set -o pipefail
./vortex-ffi/build/test/vortex_ffi_test 2>&1 | rustfilt
ctest --test-dir vortex-ffi/build -N

@myrrc myrrc Jun 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've already built the binary

ctest --test-dir vortex-ffi/build --output-on-failure --timeout 120 -V 2>&1 | rustfilt

@myrrc myrrc Jun 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ctest convolutes the output on errors, so I'd not do this

- name: Run examples
run: |
set -o pipefail
Expand Down
Loading